Integrated terminal: Shell args not honored on Windows

[chrmarti]

Testing #8222

• VSCode Version: Code - Insiders 1.3.0-insider (d0c2b89, 2016-06-28T05:07:32.441Z)
• OS Version: Windows_NT ia32 6.3.9600

Steps to Reproduce:

1. Using the following settings:
   "terminal.integrated.shell.windows": "E:\cygwin64\bin\bash.exe",
   "terminal.integrated.shellArgs.windows": ["-v"]
2. Bash should echo all lines read, open terminal and run: echo 123
3. "echo 123" isn't echoed (only "123" is)

[Tyriar]

Going to investigate for June, may not be able to get a fix though.

[Tyriar]

Upstream issue: chjj/pty.js#137, going to remove the config for the time being.

[Bigous]

just to help,
The issue is that on windows there is no shellArgs on settings (linux and osx have).
version 1.3.1 is still lacking this option.

[Bigous]

One can use bash from git too so you can test it without having to install cygwin.

and test with the parameters:

    // The path of the shell that the terminal uses on Windows.
    "terminal.integrated.shell.windows": "C:\\Program Files\\Git\\usr\\bin\\bash.exe",
    "terminal.integrated.shellArgs.windows": ["--login", "-i"],

it shoul'd open the bash with your windows profile loaded (with environment variables set among other thins).
try to enter the command ls and see if it returns the list of files.

[Tyriar]

@Bigous I removed the setting as it doesn't work in the library we're using. So this needs to be fixed in pty.js before we can add it back.

[Bigous]

Workaround: Create a batch file and set it as your windows shell. Mine is this.

[the-ress]

I've created a pull request with the fix here: chjj/pty.js#175

[Tyriar]

@the-ress awesome! I'll test this out on vscode's fork soon and if all works well it should land in v1.7.

[Tyriar]

Fixed thanks to @the-ress's pull request! You can try this out in the Insiders build tomorrow or in stable v1.7.

[daviwil]

That is awesome news, will save me a ton of trouble. Thanks a lot @the-ress!

[daviwil]

This is working perfectly for me now with the Terminal API in today's Insiders build. Thanks again @the-ress!

[bagofmice]

I notice that this is still a problem for terminals on windows in 1.13. I've created a batch file workaround in an extension here:
https://marketplace.visualstudio.com/items?itemName=bagonaut.mongogo

[wycats]

I've hit this issue on the latest stable (1.15) and reverted back to cmd as my default shell. Any idea why it was believed to be solved but regressed?