Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ini #13648 #13923

Merged
merged 2 commits into from
Oct 27, 2016
Merged

fix ini #13648 #13923

merged 2 commits into from
Oct 27, 2016

Conversation

Ikuyadeu
Copy link
Contributor

Divided ini file(use comment ;) and other like ini file (use comment #)
and use INI syntax highlighting for Sublime Text 2

related #8709

@mention-bot
Copy link

@Ikuyadeu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma, @aeschli and @bpasero to be potential reviewers.

@aeschli
Copy link
Contributor

aeschli commented Oct 18, 2016

Thanks @Ikuyadeu . There's a spelling mistake in propaties. Other than that the changes look good.

@Ikuyadeu
Copy link
Contributor Author

Ikuyadeu commented Oct 19, 2016

@aeschli , Thank you for correcting my mistakes.
typo was fixed propaties to properties.

@aeschli aeschli merged commit 2b67a15 into microsoft:master Oct 27, 2016
@aeschli
Copy link
Contributor

aeschli commented Oct 27, 2016

Thanks @Ikuyadeu, PR accepted!

@aeschli aeschli added this to the October 2016 milestone Oct 27, 2016
@aeschli
Copy link
Contributor

aeschli commented Oct 27, 2016

I made a change to use the same grammar ("./syntaxes/properties.plist") for both ini and properties.
It's not clear where https://github.com/clintberry/sublime-text-2-ini comes from. We can only add it to VSCode if the license allows it.

@Ikuyadeu Ikuyadeu deleted the fix_ini branch October 28, 2016 04:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants