Support opening files through URL handling (fixes #4883)

[KattMingMing]

No description provided.

[mention-bot]

@KattMingMing, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma, @bpasero and @jrieken to be potential reviewers.

[msftclas]

Hi @KattMingMing, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

[msftclas]

@KattMingMing, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

[joaomoreno]

Fixes #4883

[joaomoreno]

The intentions are good, and it appears at a first glance to just work. But there might be a better way to do this.

Right now, the URLService will send the onOpenURL event to the last focused Window. In the case of opening a file, that might not be the ideal scenario. Think about having two windows, each with a workspace open: A and B. While A is the last focused one, you can open a vscode:file/B/foo.js URL; ideally, the file would open in the window of workspace B, and not in A as it would occur given this PR.

For that reason, it might be better to react to the onOpenURL event in the main process, where we control all the windows.

I suggest to do it in the WindowsService and just call the open method in this other guy. That area is currently a heavy reconstruction site but I think you'll do fine.

[jrieken]

fyi - we have an OpenerService which should do this

[joaomoreno]

@jrieken That's already too late, since that service is scoped to an EditorService, which is scoped to a specific Window.

[KattMingMing]

@joaomoreno Great, thanks for the feedback!

[KattMingMing]

@joaomoreno I removed the implementation from the EditorService and moved the listener and implementation inside of the WindowsService. The opening behavior is now the same as running code -g -r /path/to/file. Thanks again for taking the time to review

[joaomoreno]

Good job! I just cleaned up a little bit more, added a disposables list and removed the method declaration in the service interface, we want this to be private within the service itself.

🍻 Thanks!

[KattMingMing]

@joaomoreno Awesome, thanks for the update! 🍻