[FrameworkBundle] Add vscode editor to ide config #28679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please double confirm you tried it for real and it works for you? |
javiereguiluz
approved these changes
Oct 2, 2018
There was a problem hiding this comment.
Here is the official Visual Code docs about this format: https://code.visualstudio.com/docs/editor/command-line#_opening-vs-code-with-urls
And here is the implementation in their source code: https://github.com/Microsoft/vscode/blob/d3a6a234497b9028b02f20465b9b6d1a0158d2f1/src/vs/code/node/paths.ts#L100
nicolas-grekas
approved these changes
Oct 2, 2018
|
Thank you @lexcast. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2018
…cast) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] Add vscode editor to ide config | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#10424 <!-- required for new features --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Support for uri handler (added [here](microsoft/vscode#15320)) in vscode editor. Commits ------- 05935d8 Add vscode editor to ide config
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 2, 2018
This PR was merged into the master branch. Discussion ---------- Mention vscode on IDE config <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> See symfony/symfony#28679 Commits ------- 0fdbdbb Update framework.rst
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for uri handler (added here) in vscode editor.