Fix bug in decorationRenderHelper #18361

Merged
merged 1 commit into from Jan 19, 2017

Projects

None yet

5 participants

@nojvek
Member
nojvek commented Jan 10, 2017

getCSSTextForModelDecorationContentClassName will not escape ' in contentText since its escaping " rather than '

_CSS_MAPcontentText: 'content:'{0}';' uses single apostrophe so we need to escape ' rather than "

This is a bug that was always present and breaks inlineValueDebugging feature I am working on #16129

@nojvek nojvek Fix bug in decorationRenderHelper
getCSSTextForModelDecorationContentClassName will not escape ' in contentText since its escaping " rather than '

_CSS_MAPcontentText: 'content:\'{0}\';' uses single apostrophe so we need to escape ' rather than "

This is a bug that was always present and breaks inlineValueDebugging feature I am working on #16129
25eb362
@nojvek
Member
nojvek commented Jan 10, 2017

@isidorn any chance you could take a quick look at this. This is ported from the other PR as you had requested.

@nojvek
Member
nojvek commented Jan 10, 2017

Notes from other PR:
This doesn't have side effects because its only escaping the contentText property and that's the only usage of it.

Without this fix, python string values won't show up. Since python strings show up as 'cat bat mat' in the watches view.

@isidorn
Contributor
isidorn commented Jan 10, 2017

@alexandrudima as @nojvek explains the other PR #16129 depends on this as this seems to be the issue with handling of python words.

@aeschli aeschli merged commit 906d4df into Microsoft:master Jan 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aeschli aeschli added this to the January 2017 milestone Jan 19, 2017
@aeschli
Contributor
aeschli commented Jan 19, 2017

Thanks @nojvek !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment