Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in decorationRenderHelper #18361

Merged
merged 1 commit into from
Jan 19, 2017
Merged

Fix bug in decorationRenderHelper #18361

merged 1 commit into from
Jan 19, 2017

Commits on Jan 10, 2017

  1. Fix bug in decorationRenderHelper 

    getCSSTextForModelDecorationContentClassName will not escape ' in contentText since its escaping " rather than '

_CSS_MAPcontentText: 'content:\'{0}\';' uses single apostrophe so we need to escape ' rather than "

This is a bug that was always present and breaks inlineValueDebugging feature I am working on #16129
    @nojvek
    nojvek committed Jan 10, 2017
    Configuration menu
    Copy the full SHA
    25eb362 View commit details
    Browse the repository at this point in the history