Fix labels unit tests + root displayed as '.. #18575

Merged
merged 4 commits into from Jan 23, 2017

Projects

None yet

3 participants

@hun1ahpu
Contributor

Iteration on #12040

Unit tests should work for MacOS. Couldn't verify it though.
Also root path is displayed as '.'

@hun1ahpu hun1ahpu Fix labels unit tests + root displayed as '..
3ddce41
@bpasero bpasero was assigned by Tyriar Jan 16, 2017
@bpasero bpasero Merge remote-tracking branch 'upstream/master' into fixLabelsTests
a913223
@bpasero
Member
bpasero commented Jan 16, 2017 edited

@hun1ahpu not a good fix, please keep using nativeSep, otherwise you end up with slashes on windows as part separator which is not correct, it should be "\". I suggest to fix your tests by using nativeSep in the tests too.

@bpasero bpasero modified the milestone: February 2017, January 2017 Jan 16, 2017
@bpasero
Member
bpasero commented Jan 18, 2017

@hun1ahpu did you get my message?

@hun1ahpu
Contributor

@bpasero Yes, i agree it's a bad fix. Will send a new iteration today-tomorrow.
Thanks.

@bpasero
Member
bpasero commented Jan 19, 2017

@hun1ahpu great 👍

hun1ahpu added some commits Jan 21, 2017
@hun1ahpu hun1ahpu Creating 2 separate tests for windows and not 2fd302f
@hun1ahpu hun1ahpu Merge branch 'fixLabelsTests' of https://github.com/hun1ahpu/vscode i…
…nto fixLabelsTests
3ed69a1
@hun1ahpu
Contributor

@bpasero decided to create 2 separate unit tests. it's not easy to read when using nativeSep.

@bpasero
Member
bpasero commented Jan 23, 2017

@hun1ahpu looks good, thanks.

@bpasero bpasero merged commit 882244e into Microsoft:master Jan 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment