Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape paths in npm.sh to fix #20907 #21010

Merged
merged 1 commit into from Apr 11, 2017
Merged

Escape paths in npm.sh to fix #20907 #21010

merged 1 commit into from Apr 11, 2017

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2017

I had cloned vscode into a folder within iCloud Drive ~/Library/Mobile Documents/com~apple~CloudDocs/vscode and on ./scripts/npm.sh i I was getting:

usage: dirname path
usage: dirname path
cat: /package.json: No such file or directory

This pull request adds escaping (not tested on Linux). Closes #20907.

@mention-bot
Copy link

@flagello, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @bpasero to be potential reviewers.

@msftclas
Copy link

Hi @flagello, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@ghost ghost mentioned this pull request Feb 21, 2017
@ghost ghost changed the title Escape paths to fix Microsoft/vscode#20907 Escape paths in npm.sh to fix #20907 Feb 21, 2017
@joaomoreno joaomoreno added this to the March 2017 milestone Feb 22, 2017
@ghost ghost closed this Mar 6, 2017
@ghost ghost deleted the escape_paths_install_bash_script branch March 6, 2017 06:08
@ghost ghost restored the escape_paths_install_bash_script branch March 10, 2017 15:25
@ghost
Copy link
Author

ghost commented Mar 10, 2017

Closed by error while cleaning up

@ghost ghost reopened this Mar 10, 2017
@msftclas
Copy link

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@joaomoreno joaomoreno merged commit 7e4b90e into microsoft:master Apr 11, 2017
@joaomoreno
Copy link
Member

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants