Change behavior of home/end button #21338
Conversation
|
@misoguy, It will cover your contributions to all Microsoft-managed open source projects. |
|
@misoguy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @egamma to be potential reviewers. |
|
Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience! |
|
@misoguy, |
|
@rebornix How does the PR look? Is there room for improvement? or could this be merged as is? |
misoguy
changed the title
|
@rebornix It'd be nice to get a feedback on this when you get the time :) |
| @@ -1234,11 +1234,17 @@ export class Cursor extends EventEmitter { | |||
| } | |||
|
|
|||
| private _moveToBeginningOfLine(inSelectionMode: boolean, ctx: IMultipleCursorOperationContext): boolean { | |||
| return this._invokeForAll(ctx, (cursorIndex: number, oneCursor: OneCursor, oneCtx: IOneCursorOperationContext) => OneCursorOp.moveToBeginningOfLine(oneCursor, inSelectionMode, oneCtx)); | |||
There was a problem hiding this comment.
_invokeForAll is for multi cursor, you may want to keep it.
There was a problem hiding this comment.
After taking a look at the code, the method _cursorMove which I used instead of _invokeForAll uses _invokeForAll internally so I'm guessing it's not a problem?
However, I think we do need to clarify how Home and End command should behave in multi cursor mode. I'll raise this question in the related issue directly.
|
Thank you @misoguy ! ❤️ |
|
@alexandrudima Thank you for merging this PR 👍 |
Fixes #19644