Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inner whitespace on Toggle Block Comment. Fixes #30656 & #30729 #30818

Merged
merged 2 commits into from
Jul 18, 2017

Conversation

cleidigh
Copy link
Contributor

@rebornix

  • adjusted whitespace in similar fashion to single-line comment
  • everything language independent

@mention-bot
Copy link

@cleidigh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @alexandrudima to be potential reviewers.

@cleidigh cleidigh changed the title Remove inner whitespace on toggle block comment. Fixes #30656 & #30729 Remove inner whitespace on Toggle Block Comment. Fixes #30656 & #30729 Jul 16, 2017
@rebornix
Copy link
Member

@cleidigh thanks, it looks pretty good. Do you mind adding test cases which can cover what you added for block comments? Once we have tests for them, we can get it merged.

@rebornix rebornix added this to the July 2017 milestone Jul 18, 2017
@cleidigh
Copy link
Contributor Author

@rebornix
Sounds good!
Just have to familiarize myself with the test approach...
Will attempt to do as quickly as possible.

@cleidigh
Copy link
Contributor Author

@rebornix
Okay, I added test cases and ran the test suite.
I think this should cover the new cases.

@rebornix
Copy link
Member

@cleidigh thank you very much, this is really awesome!

@rebornix rebornix merged commit 2ca72ac into microsoft:master Jul 18, 2017
@cleidigh
Copy link
Contributor Author

@rebornix
Cool. Working on VCS is great and important for me being disabled. Code's accessibility
it's great and I intend to help add more ;-)

@cleidigh cleidigh deleted the blockcomment-spaces/bug branch July 18, 2017 18:25
@rebornix
Copy link
Member

@cleidigh look forward to see more contributions from you 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants