Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve search aria label generation performance #34491

Merged
merged 1 commit into from Sep 19, 2017
Merged

Improve search aria label generation performance #34491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/vs/workbench/parts/search/browser/searchResultsView.ts
View file
Open in desktop
Expand Up @@ -310,12 +310,12 @@ export class SearchAccessibilityProvider implements IAccessibilityProvider {
const match = <Match>element;
const searchModel: SearchModel = (<SearchResult>tree.getInput()).searchModel;
const replace = searchModel.isReplaceActive() && !!searchModel.replaceString;
const preview = match.preview();
const matchString = match.getMatchString();
const range = match.range();
if (replace) {
return nls.localize('replacePreviewResultAria', "Replace term {0} with {1} at column position {2} in line with text {3}", preview.inside, match.replaceString, range.startColumn + 1, match.text());
return nls.localize('replacePreviewResultAria', "Replace term {0} with {1} at column position {2} in line with text {3}", matchString, match.replaceString, range.startColumn + 1, match.text());
}
return nls.localize('searchResultAria', "Found term {0} at column position {1} in line with text {2}", preview.inside, range.startColumn + 1, match.text());
return nls.localize('searchResultAria', "Found term {0} at column position {1} in line with text {2}", matchString, range.startColumn + 1, match.text());
}
return undefined;
}
Expand Down