New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tweaks for #45406 #45691

Merged
merged 4 commits into from Mar 14, 2018

Conversation

Projects
None yet
2 participants
@chryw
Copy link
Member

chryw commented Mar 13, 2018

@isidorn

  • current-and-brekapoint.svg and stackframe-and-breakpoint.svg fixed
  • I tweaked the breakpoint size.

They're are technically perfect circles. Just at certain sizes the edge pixels and straight lines fall off grid (decimal numbers). Is this good enough? Note that screen capture can be different than actual render result on difference computers. Please test on your side before merging.
aqktajnjic

  • I made the pause.svg icon skinnier. The edges in middle will fall off grid and look slightly fuzzy as a compromise. But the overall weight of the icon is reduced.
    image

  • I changed the inline block size for the yellow arrow since the svgs are responsive now.
    image

#45406

@isidorn isidorn merged commit d8600f2 into Microsoft:master Mar 14, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla All CLA requirements met.
Details

@isidorn isidorn added this to the March 2018 milestone Mar 14, 2018

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Mar 14, 2018

@chryw just tried it out and everything looks good to me. Awesome work.
Some people might complaing that the breakpoint size decreased but I like it this way. So let's wait for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment