Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug icon polish #45406

Closed
4 tasks done
isidorn opened this issue Mar 9, 2018 · 8 comments
Closed
4 tasks done

Debug icon polish #45406

isidorn opened this issue Mar 9, 2018 · 8 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues ux User experience issues verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 9, 2018

After merging in the new icons here is still things left to be done:

  • Breakpoint hint decoration takes priority over regular breakpoint decoration. If a user hover over breakpoint it should show that decoration, not the transaparent one. For this we would need the breakpoint-hint icon back, since otherwise it is hard for me to prioritize css rules usch that this one is not respected
  • Start icon in select box looks too big - compare it to debug toolbar
  • Breakpoints have increased in size, let's decrease their size a bit
  • Restart icon looks too large

screen shot 2018-03-09 at 14 11 52

fyi @chryw

@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Mar 9, 2018
@isidorn isidorn added this to the March 2018 milestone Mar 9, 2018
@isidorn isidorn self-assigned this Mar 9, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Mar 9, 2018

@chryw also note that I brought back the breakpoints-activate-inverse.svg which you have removed (i believe by accident).

@chryw
Copy link
Contributor

chryw commented Mar 9, 2018

@isidorn thanks!
I already have some of these fixed on my own fork. Just tackling some conflicts now. will keep you posted!

@isidorn
Copy link
Contributor Author

isidorn commented Mar 9, 2018

@chryw awesome, thanks!

@chryw chryw mentioned this issue Mar 9, 2018
5 tasks
@isidorn
Copy link
Contributor Author

isidorn commented Mar 13, 2018

  • current-and-brekapoint.svg and stackframe-and-breakpoint.svg are not correct, since they only have the arrow, not the red breakpoint dot
  • With the new breakpoint size the conditional breakpoint icon does not really work since the equality lines are too far apart (this can also be seen in your screenshot on the BREAKPOINTS view)
  • The new breakpoint size makes the breakpoints looks more square like, and not like a perfect circle. I am not sure if this is just me or the shape of the breakpoint also changed, not only the size?
    screen shot 2018-03-13 at 10 00 47
  • Pause buttton might need to have the two parallel lines closer - feels too strong now imho
    screen shot 2018-03-13 at 12 36 35

@isidorn isidorn added the ux User experience issues label Mar 13, 2018
@chryw chryw mentioned this issue Mar 13, 2018
4 tasks
isidorn added a commit that referenced this issue Mar 14, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Mar 14, 2018

@chryw Everything is tackled except my comment about the conditional breakpoint - I still feel like the parallel horizontal lines are too far apart and bringing them closer would make it look more like an equality sign which is the point of the icon. What do you think?

screen shot 2018-03-14 at 11 15 41

@chryw
Copy link
Contributor

chryw commented Mar 14, 2018

@isidorn I did try pulling each line 0.5px closer to center but the render result was fuzzy because lines fall off grid. How about very close but on grid (at default 19px line height)?
image

@isidorn
Copy link
Contributor Author

isidorn commented Mar 15, 2018

@chryw this looks great! So yes yes

isidorn added a commit that referenced this issue Mar 16, 2018
Conditional breakpoint icon polish for #45406
@isidorn
Copy link
Contributor Author

isidorn commented Mar 16, 2018

@chryw we seem to have done everything on the list. Closing this item.
FYI one use so far complained that we reduced the breakpoint size, but let's wait for more feedback. Just so you know that it might happen that we have to bring back the old size some time next week if more poeple do not like it.

Thanks again for your great help

@isidorn isidorn closed this as completed Mar 16, 2018
@rebornix rebornix added the verified Verification succeeded label Mar 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues ux User experience issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants