-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug icon polish #45406
Comments
@chryw also note that I brought back the breakpoints-activate-inverse.svg which you have removed (i believe by accident). |
@isidorn thanks! |
@chryw awesome, thanks! |
@chryw Everything is tackled except my comment about the conditional breakpoint - I still feel like the parallel horizontal lines are too far apart and bringing them closer would make it look more like an equality sign which is the point of the icon. What do you think? |
@isidorn I did try pulling each line 0.5px closer to center but the render result was fuzzy because lines fall off grid. How about very close but on grid (at default 19px line height)? |
@chryw this looks great! So yes yes |
Conditional breakpoint icon polish for #45406
@chryw we seem to have done everything on the list. Closing this item. Thanks again for your great help |
After merging in the new icons here is still things left to be done:
fyi @chryw
The text was updated successfully, but these errors were encountered: