New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the key bindings for first and last selection in suggestions. #45881

Merged
merged 1 commit into from Mar 16, 2018

Conversation

Projects
None yet
2 participants
@pradeepmurugesan
Copy link
Contributor

pradeepmurugesan commented Mar 15, 2018

For #43511

@jrieken jrieken self-assigned this Mar 15, 2018

@jrieken jrieken added this to the March 2018 milestone Mar 15, 2018

weight: weight,
kbExpr: EditorContextKeys.textFocus,
primary: KeyCode.End,
secondary: [KeyCode.End],

This comment has been minimized.

@jrieken

jrieken Mar 15, 2018

Member

Use secondary only when the key code is different from primary 🤓

This comment has been minimized.

@pradeepmurugesan
weight: weight,
kbExpr: EditorContextKeys.textFocus,
primary: KeyCode.Home,
secondary: [KeyCode.Home],

This comment has been minimized.

@jrieken

This comment has been minimized.

@pradeepmurugesan

@jrieken jrieken added the suggest label Mar 15, 2018

@pradeepmurugesan pradeepmurugesan force-pushed the pradeepmurugesan:home-end-keys-in-suggestion branch from d6dbc2c to be5030b Mar 15, 2018

@pradeepmurugesan

This comment has been minimized.

Copy link
Contributor

pradeepmurugesan commented Mar 15, 2018

@jrieken sorry my bad.. Didn't know about the secondary thing. Fixed now..

@jrieken

This comment has been minimized.

Copy link
Member

jrieken commented Mar 16, 2018

Thanks, looking good

@jrieken
Copy link
Member

jrieken left a comment

👍

@jrieken jrieken merged commit 234defc into Microsoft:master Mar 16, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.

@jrieken jrieken added the on-testplan label Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment