Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort option for breadcrumb symbol trees #61420

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Add sort option for breadcrumb symbol trees #61420

merged 2 commits into from
Oct 23, 2018

Conversation

ryanclarke
Copy link
Contributor

'Position' shows symbols in file position order (default).
'Name' shows symbols in alphabetical order.
'Type' shows the symbols in symbol type order.

The configuration setting is not watched anywhere since the
breadcrumbs tree view is transient and would disappear in
changing the setting.

Implements #56695
Effected by styling bug #61365

'Position' shows symbols in file position order (default).
'Name' shows symbols in alphabetical order.
'Type' shows the symbols in symbol type order.

The configuration setting is not watched anywhere since the
breadcrumbs tree view is transient and would dissapear in
changing the setting.
@msftclas
Copy link

msftclas commented Oct 21, 2018

CLA assistant check
All CLA requirements met.

@jrieken jrieken self-assigned this Oct 22, 2018
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look pretty good so far. Please update the setting name and we are good

src/vs/workbench/browser/parts/editor/breadcrumbs.ts Outdated Show resolved Hide resolved
@jrieken jrieken added this to the October 2018 milestone Oct 22, 2018
outlineSort is now symbolSortOrder
@jrieken
Copy link
Member

jrieken commented Oct 23, 2018

looking good. Thanks @ryanclarke 👏

@jrieken jrieken merged commit d1206c6 into microsoft:master Oct 23, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants