Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude/include commandsToSkipShell instead of butchering user settings file #66179

Merged
merged 8 commits into from Jan 8, 2019
Merged

Exclude/include commandsToSkipShell instead of butchering user settings file #66179

merged 8 commits into from Jan 8, 2019

Conversation

usernamehw
Copy link
Contributor

Fixes #19770

"terminal.integrated.commandsToSkipShell": [
    "workbench.action.toggleSidebarVisibility",
    "-workbench.action.quickOpen"
],

@Tyriar Tyriar added this to the December/January 2019 milestone Jan 7, 2019
This was referenced Jan 7, 2019
Closed
Closed
Tyriar
Tyriar approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for making this less horrible 😄, will merge when CI passes

Tyriar added a commit to microsoft/vscode-docs that referenced this pull request Jan 8, 2019
@Tyriar
Explain new commandsToSkipShell format
f70ff3e 
See microsoft/vscode#66179
@Tyriar
Copy link
Member

Tyriar commented Jan 8, 2019

Explained new format in docs: microsoft/vscode-docs@f70ff3e

@Tyriar Tyriar merged commit 439e20c into microsoft:master Jan 8, 2019
@usernamehw usernamehw deleted the terminal_skip_lines branch January 8, 2019 18:27
@Tyriar Tyriar mentioned this pull request Feb 12, 2019
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
December/January 2019
Development

Successfully merging this pull request may close these issues.

terminal.integrated.commandsToSkipShell is unintuitive
2 participants
@usernamehw @Tyriar