New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude/include commandsToSkipShell instead of butchering user settings file #66179

Merged
merged 8 commits into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@usernamehw
Copy link
Contributor

usernamehw commented Jan 7, 2019

Fixes #19770

"terminal.integrated.commandsToSkipShell": [
    "workbench.action.toggleSidebarVisibility",
    "-workbench.action.quickOpen"
],
@Tyriar

Tyriar approved these changes Jan 8, 2019

Copy link
Member

Tyriar left a comment

Thanks a lot for making this less horrible 😄, will merge when CI passes

Tyriar added a commit to Microsoft/vscode-docs that referenced this pull request Jan 8, 2019

@Tyriar

This comment has been minimized.

Copy link
Member

Tyriar commented Jan 8, 2019

Explained new format in docs: Microsoft/vscode-docs@f70ff3e

Tyriar added some commits Jan 8, 2019

Break terminal dependency on other components
Just hardcode the command names, it's a soft dep anyway

@Tyriar Tyriar merged commit 439e20c into Microsoft:master Jan 8, 2019

@usernamehw usernamehw deleted the usernamehw:terminal_skip_lines branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment