Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger console recognizes italic ansi code #67511

Merged
merged 13 commits into from
Mar 4, 2019
Merged

debugger console recognizes italic ansi code #67511

merged 13 commits into from
Mar 4, 2019

Conversation

flurmbo
Copy link
Contributor

@flurmbo flurmbo commented Jan 30, 2019

Fixes #67510

@isidorn
Copy link
Contributor

isidorn commented Jan 30, 2019

Thanks for your PR. Not for endgame, will review once I am back from vacation in 2 weeks

@isidorn isidorn added this to the February 2019 milestone Jan 30, 2019
@isidorn
Copy link
Contributor

isidorn commented Feb 20, 2019

This looks good.
@flurmbo in order to merge this in can you please:

  1. resolve the confilicts
  2. test that it works in latest
  3. write unit tests that cover your case. Here's a pointer https://github.com/Microsoft/vscode/blob/f6caa53cdd87f3fcee7de78d6a5b60a6835cde29/src/vs/workbench/contrib/debug/test/browser/debugANSIHandling.test.ts#L1

@isidorn isidorn modified the milestones: February 2019, On Deck Feb 20, 2019
@flurmbo
Copy link
Contributor Author

flurmbo commented Feb 22, 2019

@isidorn sure I'll try to get to it in the next few days!

@flurmbo
Copy link
Contributor Author

flurmbo commented Feb 26, 2019

Hey @isidorn I made the changes you asked for, let me know what you think!

@isidorn
Copy link
Contributor

isidorn commented Feb 26, 2019

Thanks a lot. This week we are in endgame which means we only bugfix and take limited changes. Due to that I am assigning this to march and I will probably review next week.

@isidorn isidorn modified the milestones: On Deck, March 2019 Feb 26, 2019
@isidorn
Copy link
Contributor

isidorn commented Mar 4, 2019

@flurmbo great work, merging this in. Nice tests
Thanks a lot!

@isidorn isidorn merged commit 5b324d0 into microsoft:master Mar 4, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug console does not support italic ANSI escape sequence
2 participants