-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debugger console recognizes italic ansi code #67511
Conversation
Thanks for your PR. Not for endgame, will review once I am back from vacation in 2 weeks |
This looks good.
|
@isidorn sure I'll try to get to it in the next few days! |
Hey @isidorn I made the changes you asked for, let me know what you think! |
Thanks a lot. This week we are in endgame which means we only bugfix and take limited changes. Due to that I am assigning this to march and I will probably review next week. |
@flurmbo great work, merging this in. Nice tests |
Fixes #67510