Blame Sequence File Changes #1716
Conversation
|
@kaadhina Please review these changes |
| /// </summary> | ||
| /// <returns>Guid test id</returns> | ||
| private Guid GetTestId() | ||
| { |
| @@ -155,7 +155,7 @@ private void EventsTestCaseStart(object sender, TestCaseStartEventArgs e) | |||
| EqtTrace.Info("Blame Collector : Test Case Start"); | |||
| } | |||
|
|
|||
| this.testSequence.Add(e.TestElement); | |||
| this.testSequence.Add(new BlameTestObject(e.TestElement)); | |||
| this.testStartCount++; | |||
There was a problem hiding this comment.
Dictionary and list used.
| @@ -55,7 +55,7 @@ protected XmlReaderWriter(IFileHelper fileHelper) | |||
| /// The file Path. | |||
| /// </param> | |||
| /// <returns>File path</returns> | |||
| public string WriteTestSequence(List<TestCase> testSequence, string filePath) | |||
There was a problem hiding this comment.
TestCase [](start = 45, length = 8)
check for outcome/result
There was a problem hiding this comment.
There is no outcome field in TestCase object.
| @@ -198,7 +198,7 @@ public void TriggerSessionEndedHandlerShouldGetDumpFileIfCollectDumpOnExitIsEnab | |||
|
|
|||
| // Setup | |||
| this.mockProcessDumpUtility.Setup(x => x.GetDumpFile()).Returns(this.filepath); | |||
| this.mockBlameReaderWriter.Setup(x => x.WriteTestSequence(It.IsAny<List<TestCase>>(), It.IsAny<string>())) | |||
| this.mockBlameReaderWriter.Setup(x => x.WriteTestSequence(It.IsAny<List<BlameTestObject>>(), It.IsAny<string>())) | |||
There was a problem hiding this comment.
UTs for both completed and not completed
There was a problem hiding this comment.
Added UTs in XmlReaderWriterTests.cs
| // Add the test object to the dictionary. | ||
| this.testObjectDictionary.Add(blameTestObject.Id, blameTestObject); | ||
|
|
||
| // Increment test start count. | ||
| this.testStartCount++; |
There was a problem hiding this comment.
this.testStartCount++; [](start = 12, length = 22)
Do we still need this>?
There was a problem hiding this comment.
We will have to check for entire dictionary if any test remains incomplete to decide if sequence is to be written to file. This makes an easier check.
| var testCaseList = xmlReaderWriter.ReadTestSequence(filePath); | ||
| File.Delete(filePath); | ||
|
|
||
| Assert.AreEqual(testCaseList.First().FullyQualifiedName, "Abc.UnitTest1"); |
There was a problem hiding this comment.
Will add that.
| .Returns(this.filepath); | ||
|
|
||
| this.mockDataColectionEvents.Raise(x => x.TestCaseStart += null, new TestCaseStartEventArgs(testcase)); | ||
| this.mockDataColectionEvents.Raise(x => x.SessionEnd += null, new SessionEndEventArgs(this.dataCollectionContext)); | ||
|
|
||
| // Verify WriteTestSequence Call | ||
| this.mockBlameReaderWriter.Verify(x => x.WriteTestSequence(It.IsAny<List<TestCase>>(), It.IsAny<string>()), Times.Once); | ||
| this.mockBlameReaderWriter.Verify(x => x.WriteTestSequence(It.IsAny<List<Guid>>(), It.IsAny<Dictionary<Guid, BlameTestObject>>(), It.IsAny<string>()), Times.Once); | ||
| } |
There was a problem hiding this comment.
validation for values in the dictionary and list, we should validate that iscompleted, fqdn, display name etc were set properly
There was a problem hiding this comment.
Added validations for dictionary and list.
|
@dotnet-bot test this please |
Blame Sequence File Changes
Added Display name and Is Test Completed in the sequence file that is generated by BlameDataCollector