Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use log in VSTestLogsTask #1882

Merged
merged 3 commits into from
Jan 10, 2019
Merged

use log in VSTestLogsTask #1882

merged 3 commits into from
Jan 10, 2019

Conversation

adamralph
Copy link
Contributor

@adamralph adamralph commented Dec 30, 2018

Description

See https://github.com/Microsoft/vstest/pull/1867/files#r240614971

Before this change, messages for build start/completion, and a missing IsTestProject property, are printed to the console only, and regardless of the current verbosity level.

After this change, these messages are printed to all configured loggers, with the build start/completion messages only at normal verbosity or higher, and the IsTestProject property message at detailed verbosity or higher.

Related issue

@singhsarab
Copy link
Contributor

@adamralph As part of the description, please mention how this change affects the behavior and what options does the user needs to use to see this message.

@adamralph
Copy link
Contributor Author

@singhsarab done.

@singhsarab singhsarab merged commit e59d9a8 into microsoft:master Jan 10, 2019
@adamralph adamralph deleted the use-log branch January 10, 2019 19:46
@adamralph
Copy link
Contributor Author

🎉 thanks for the merge!

Do you know which version of the .NET SDK this will be released in? There's no urgency, I'd just like to know when to expect it.

@adamralph
Copy link
Contributor Author

Which version will this be released in?

@singhsarab
Copy link
Contributor

@mayankbansal018 is tracking that. Mayank, let's expedite the release.

@adamralph
Copy link
Contributor Author

Any update? I don't necessarily want to expedite the release. I'd just like to know which version it will be released in, so I can set my expectations accordingly.

@mayankbansal018
Copy link
Contributor

@adamralph we have already made a release of Testpaltform, please check the releases, this is available in latest pre-release.

@adamralph
Copy link
Contributor Author

@singhsarab
Copy link
Contributor

singhsarab commented Feb 22, 2019

@adamralph We might have missed adding this to the release notes.
It was inserted into the dotnet cli via dotnet/cli#10654

@adamralph
Copy link
Contributor Author

@singhsarab OK, but in any case, this will be released in 16.0.0, correct? Would it be reasonable to put it on the 16.0.0 milestone, so that anyone browsing the PR knows when to expect the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants