Working directory fix #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we please add an end to end test for this? Basically multitarget a test project and have a test like below: |
codito
approved these changes
Jan 19, 2017
codito
pushed a commit
that referenced
this pull request
Jan 20, 2017
* Fixed the working directory for the dotnet.exe to source directory. * Adding the acceptance test for the working directory fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the working directory for the dotnet.exe to source directory.
Output for Directory.CurrentDirectory for net46 and netcoreapp1.0 both are similar, as in point to source directory.
Ongoing Validations (All done with relative path fix):