Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical and unbelievable bug makes impossible to deploy to IIS #115

Closed
shamnigurat opened this issue Sep 29, 2016 · 2 comments
Closed

Critical and unbelievable bug makes impossible to deploy to IIS #115

shamnigurat opened this issue Sep 29, 2016 · 2 comments
Assignees

Comments

@shamnigurat
Copy link

shamnigurat commented Sep 29, 2016

I'll be brief.

  1. Look closely at this:
    Deploy-Website -webDeployPkg $WebDeployPackage -webDeployParamFile $WebDeployParamFile -overRiderParams $OverRideParams -websiteName $websiteName -excludeFilesFromAppData $excludeFilesFromAppData -removeAdditionalFiles $removeAdditionalFiles -takeAppOffline $takeAppOffline -additionalArguments $AdditionalArguments

There is the $websiteName parameter.

  1. Look closely at this:
    function Deploy-Website
    {
    param(
    [string]$webDeployPkg,
    [string]$webDeployParamFile,
    [string]$overRiderParams,
    [string]$removeAdditionalFiles,
    [string]$excludeFilesFromAppData,
    [string]$takeAppOffline,
    [string]$additionalArguments
    )

I'm intrested in what has happened with the $websiteName parameter, uh?

  1. Look at the three lines above:
    $msDeployCmdArgs = [string]::Format(' -verb:sync -source:package="{0}" {1} -dest:auto -retryAttempts:3 -retryInterval:3000', $webDeployPackage, $msDeployCmdArgs)

The curious question: HOW IS IT SUPPOSED TO DEPLOY TO IIS's SITE DEFINED BY $websiteName PARAMETER (the value comes from the UI-from of the 'WinRM - IIS Web App Deployment' task)???

I'm in shock of how it could be possible to be so handless clown to write such miserable code.
It's called 'the hindu code'.

Hints to fix:

  1. parameter $websiteName should be passed down to the Get-MsDeployCmdArgs function;
  2. value of the 'dest' parameter for msdeploy should be iisApp:"$websiteName" instead of 'auto'.

The last question: when will be this shameful bug fixed???

@mvvsubbu mvvsubbu self-assigned this Oct 6, 2016
@mvvsubbu
Copy link
Member

mvvsubbu commented Oct 6, 2016

The parameter $websiteName is never used in Deploy-Website. Override parameters contains details about where to deploy. Unused parameter I will remove

@shamnigurat
Copy link
Author

It's unacceptable because without fixing this issue as I mentioned (#115) deployment is not working at all.
Just look at the parameters of the "WinRM - IIS Web App Deployment" task.
There is the parameter named "Website Name". Just tell me: what is this parameter for?
The information's hint tells: "Provide the name of the website for deploying the Web project to."
But this parameter is not used while deploying to IIS so I can't deploy as hint tells me!
Further more, just imagine the case: I have zipped web-package (msdeploy) and want to deploy it to IIS. All I know is the name of the web site to deploy - how can I deploy in this case (I don't know the physical path of the web site and I don't need it because I would be able to deploy on differnet environments with the same site's name!)? The "Override Parameters" doesn't work for this purpose even if I set 'name="IIS Web Application Name",value="...."' - msdeploy just tries to unpack the content of the web-package to the physical path the package was created from.
Wihtout fixing my issue the task "WimRM - IIS Web App Deployment" becomes almost useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants