Set mock tl function #161
Merged
Set mock tl function #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
commented
Oct 25, 2016
| @@ -18,17 +18,28 @@ export class TaskMockRunner { | |||
| this._answers = answers; | |||
| } | |||
|
|
|||
| public setFunction(name: string, val: any) { | |||
There was a problem hiding this comment.
This is untested. Submitting PR for discussion only at this point.
The goal of this function is to still leverage mock-task but additionally allow custom mocking for specific functions only.
There was a problem hiding this comment.
registerMockExport
ericsciple
commented
Oct 25, 2016
| if (this._answers) { | ||
| tlm.setAnswers(this._answers); | ||
|
|
||
| public run(noMockTask: boolean) { |
There was a problem hiding this comment.
Also I added a bool here whether to register mock-task. What I'm thinking is, the runner is still useful for L1 scenarios where the tl would not be mocked.
|
This makes sense |
ericsciple
force-pushed
the
users/ersciple/m108setfunction
branch
from
6df7975
to
da68cea
Compare
|
this is ready for review now |
ericsciple
force-pushed
the
users/ersciple/m108setfunction
branch
from
da68cea
to
174b596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.