Add VSMobileCenterTest task #3349
Conversation
| "name": "VSMobileCenterTest", | ||
| "friendlyName": "Visual Studio Mobile Center Test", | ||
| "description": "Test mobile app packages with Visual Studio Mobile Center", | ||
| "helpMarkDown": "Test mobile app packages to Visual Studio Mobile Center", |
There was a problem hiding this comment.
Test mobile app packages with Visual Studio Mobile Center
| "author": "Microsoft Corporation", | ||
| "version": { | ||
| "Major": 0, | ||
| "Minor": 111, |
| "label": "Mobile Center Password", | ||
| "defaultValue": "", | ||
| "required": true, | ||
| "helpMarkDown": "Visit https://mobile.azure.com/settings/profile to set your password.", |
There was a problem hiding this comment.
Add a note here to use a secret build variable for the password. We have similar text in other tasks that you can follow.
| "label": "DSym Directory", | ||
| "defaultValue": "", | ||
| "required": false, | ||
| "helpMarkDown": "Path to iOS symbol files" |
| "required": false, | ||
| "visibleRule": "locale = user", | ||
| "helpMarkDown": "Enter any two-letter ISO-639 language code along with any two-letter ISO 3166 country code in the format [language]_[country], such as en_US." | ||
| }, |
There was a problem hiding this comment.
It would be better to keep this input next to "locale" since they are related.
| "name": "framework", | ||
| "type": "pickList", | ||
| "label": "Test Framework", | ||
| "defaultValue": "appium", |
There was a problem hiding this comment.
Is "appium" the most popular or the first in alphabetical order? I would have picked "UI Test" since that is the type of test project created when a Xamarin project is created in VS.
There was a problem hiding this comment.
I opted to keep it in alphabetical order so I don't play favoritism. :)
| "defaultValue":"", | ||
| "visibleRule":"framework = appium", | ||
| "required": true, | ||
| "helpMarkDown":"Path to directory with Appium tests", |
There was a problem hiding this comment.
I think we should use a period at the end of all the help markdown text
| loggedIn = true; | ||
| } | ||
|
|
||
| // test prepare |
There was a problem hiding this comment.
My personal preference is to not do all the test runner setup ahead of time but set them up along the way. I feel it is more readable that way.
There was a problem hiding this comment.
I agree in general. The reason I am trying to setup first here is we can do some basic input validation first just to make sure user doesn't need to wait a long time before an obvious error is encountered.
| // logout | ||
| let logoutRunner = tl.tool(cliPath); | ||
| logoutRunner.arg(['logout', '--quiet']); | ||
| logoutRunner.exec(); |
There was a problem hiding this comment.
shouldn't you await on logout?
There was a problem hiding this comment.
sure, I will. This is clean up code so I didn't think we need to wait. However it's safer if we do.
yacaovsnc
force-pushed
the
users/yacao/vsmctest
branch
from
7570268
to
c5689ba
Compare
yacaovsnc
force-pushed
the
users/yacao/vsmctest
branch
from
eedb025
to
669d76e
Compare
No description provided.