Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Add support for an --ignore-engines runtime flag #1084

Closed

Conversation

KevinGrandon
Copy link
Contributor

Opening this PR for discussion and a possible direction towards #1083. Thanks for your consideration.

TODO:

  • Add tests.
  • I'm not sure if this change actually works yet, wasn't sure how I could test this locally.

Refs #1083

@octogonz
Copy link
Collaborator

octogonz commented Feb 6, 2019

Would it make more sense to model this as a permanent rush.json configuraitno? (See #817) . Or is this intended for people who simply want to ignore errors and try to build a repo for test purposes (See --bypass-policy for something similar).

@KevinGrandon
Copy link
Contributor Author

Would it make more sense to model this as a permanent rush.json configuraitno? (See #817) . Or is this intended for people who simply want to ignore errors and try to build a repo for test purposes (See --bypass-policy for something similar).

I'm not sure TBH, though consistency with --strict-peer-dependencies probably makes sense. I'm going to try to copy what #817 did. Thanks for commenting, I'll close this for now and follow-up with a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants