Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++/WinRT fit and finish with support for OS and Xaml builds #132

Merged
merged 16 commits into from Jan 18, 2019

Conversation

kennykerr
Copy link
Contributor

This update aggregates a number of tweaks and fixes driven by OS and Xaml ingesting testing.

  • Switch from pragma once to include guards to ease OS ingestion where we don’t control inclusion order.
  • Re-enable header version mismatch detection.
  • Remove stub projects that aren’t currently used (cppx, basewinrt, basex)
  • Build cppwinrt on all platforms
  • Minor code gen formatting improvements
  • Re-enable cross-binary inheritance for Xaml
  • Fix command line inconsistency between old cppwinrt and new cppwinrt
  • Port support for JavaScript delegates that I added to C++/WinRT after the fork
  • Port some warning silencing to ensure clean builds
  • Enable type trait optimizations in Visual C++ (using std::disjunction_v rather than std::disjunction)
  • Workaround for if constexpr parsing bugs in LKG7

Copy link
Member

@Scottj1s Scottj1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kennykerr kennykerr merged commit 3dc071a into master Jan 18, 2019
@kennykerr kennykerr deleted the kennykerr branch January 18, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants