Skip to content

C++/WinRT fit and finish with support for OS and Xaml builds#132

Merged
kennykerr merged 16 commits into
masterfrom
kennykerr
Jan 18, 2019
Merged

C++/WinRT fit and finish with support for OS and Xaml builds#132
kennykerr merged 16 commits into
masterfrom
kennykerr

Conversation

@kennykerr

Copy link
Copy Markdown
Contributor

This update aggregates a number of tweaks and fixes driven by OS and Xaml ingesting testing.

  • Switch from pragma once to include guards to ease OS ingestion where we don’t control inclusion order.
  • Re-enable header version mismatch detection.
  • Remove stub projects that aren’t currently used (cppx, basewinrt, basex)
  • Build cppwinrt on all platforms
  • Minor code gen formatting improvements
  • Re-enable cross-binary inheritance for Xaml
  • Fix command line inconsistency between old cppwinrt and new cppwinrt
  • Port support for JavaScript delegates that I added to C++/WinRT after the fork
  • Port some warning silencing to ensure clean builds
  • Enable type trait optimizations in Visual C++ (using std::disjunction_v rather than std::disjunction)
  • Workaround for if constexpr parsing bugs in LKG7

@kennykerr kennykerr requested a review from Scottj1s January 17, 2019 20:34

@Scottj1s Scottj1s left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kennykerr kennykerr merged commit 3dc071a into master Jan 18, 2019
@kennykerr kennykerr deleted the kennykerr branch January 18, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants