Fix New-ModuleManifest encoding in What's New 6.0

[matt9ucci]

@sdwheeler I am not sure whether it is a documentation bug or a software bug. If it is a software bug, please close this PR.

According to the New-ModuleManifest.md:

• New-ModuleManifest does not have Encoding parameter
• The encoding of the module manifest (.psd1) file created with New-ModuleManifest cmdlet depends on environment: if it is PowerShell Core running on Linux then encoding is UTF-8 (no BOM); otherwise encoding is UTF-16 (with BOM)

See NewModuleManifestCommand.cs and the following test commands:

Windows:

PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.0
PSEdition                      Core
GitCommitId                    v6.0.0
OS                             Microsoft Windows 10.0.16299
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

PS> New-ModuleManifest -Path .\test.psd1
PS> '{0:X2}' -f (Get-Content -AsByteStream -Path .\test.psd1 -ReadCount 8 -TotalCount 8)
FF FE 23 00 0D 00 0A 00

Linux:

PS /> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.0
PSEdition                      Core
GitCommitId                    v6.0.0
OS                             Linux 4.4.108-boot2docker #1 SMP Wed Dec 27 23:32:59 UTC 2017
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0


PS /> New-ModuleManifest -Path .\test.psd1
PS /> '{0:X2}' -f (Get-Content -AsByteStream -Path .\test.psd1 -ReadCount 8 -TotalCount 8)
23 0A 23 20 4D 6F 64 75

FF FE indicates BOM UTF-16 little-endian (Windows).
23 0A 23 ... indicates NoBOM (Linux).
See The Unicode Consortium FAQ.

Version(s) of document impacted

• Impacts 6 document
• Impacts 5.1 document
• Impacts 5.0 document
• Impacts 4.0 document
• Impacts 3.0 document

Reason(s) for not updating all version of documents

• The documented feature was introduced in version 6.0 of PowerShell
• This issue only shows up in version (list version(s) here) of the document
• This PR partially fixes the issue, and issue # tracks the remaining work

[saldana]

✅ Validation status: passed

File	Status	Preview URL	Details
reference/docs-conceptual/whats-new/What-s-New-in-PowerShell-Core-60.md	✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

[sdwheeler]

@joeyaiello Can you review Matt's comments here. Is this a bug in New-ModuleManifest?

[SteveL-MSFT]

The content is correct. Unfortunately I didn't notice with the encoding changes that New-ModuleManifest was still outputting UTF-16 BOM on Windows. PowerShell/PowerShell#5923 fixes this to be UTF-8 everywhere, but didn't make it in time for 6.0.0. So in 6.1.0 it'll be UTF-8. I'll leave it to you @sdwheeler to figure out how to address that in the docs in 6.1.0 timeframe.