Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8090 - Add experimental feature PSCleanBlock #8435

Merged
merged 3 commits into from Dec 17, 2021
Merged

Fixes #8090 - Add experimental feature PSCleanBlock #8435

merged 3 commits into from Dec 17, 2021

Conversation

sdwheeler
Copy link
Contributor

@sdwheeler sdwheeler commented Dec 17, 2021

PR Summary

Fixes AB#1903820 - Fixes #8090 - Add experimental feature PSCleanBlock

PR Context

Check the boxes below to indicate the content affected by this PR.

Repository or docset configuration

  • Repo documentation and configuration (.git/.github/.vscode etc.)
  • Docs build files (.openpublishing.* and build scripts)
  • Docset configuration (docfx.json, mapping, bread, module folder)

Conceptual documentation

  • Files in docs-conceptual

Cmdlet reference & about_ topics
When changing cmdlet reference or about_ topics, the changes should be copied to all
relevant versions. Check the boxes below to indicate the versions affected by this change.

  • Preview content
  • Version 7.2 content
  • Version 7.1 content
  • Version 7.0 content
  • Version 5.1 content

PR Checklist

  • I have read the contributors guide and followed the style and process guidelines
  • PR has a meaningful title
  • PR is targeted at the staging branch
  • All relevant versions updated
  • Includes content related to issues and PRs - see Closing issues using keywords.
  • This PR is ready to merge and is not Work in Progress. If the PR is work in progress,
    please add the prefix WIP: or [WIP] to the beginning of the title and remove the prefix when
    the PR is ready.

@opbld32
Copy link

opbld32 commented Dec 17, 2021

Docs Build status updates of commit cc2f3ef:

⚠️ Validation status: warnings

File Status Preview URL Details
reference/7.3/Microsoft.PowerShell.Core/About/about_Functions_Advanced_Methods.md ⚠️Warning View (powershell-7.3) Details
reference/docs-conceptual/learn/experimental-features.md ✅Succeeded View (>=powershell-5.1)

reference/7.3/Microsoft.PowerShell.Core/About/about_Functions_Advanced_Methods.md

  • Line 113, Column 1: [Warning: link-out-of-scope] File '7.3/Microsoft.PowerShell.Core/Enable-ExperimentalFeature.md' referenced by link '../Enable-ExperimentalFeature.md' will not be built because it is not included in build scope.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld32
Copy link

opbld32 commented Dec 17, 2021

Docs Build status updates of commit c8732b0:

✅ Validation status: passed

File Status Preview URL Details
reference/7.3/Microsoft.PowerShell.Core/About/about_Functions_Advanced_Methods.md ✅Succeeded View (powershell-7.3)
reference/docs-conceptual/learn/experimental-features.md ✅Succeeded View (>=powershell-5.1)
reference/docs-conceptual/whats-new/What-s-New-in-PowerShell-73.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple comments.

Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@opbld33
Copy link

opbld33 commented Dec 17, 2021

Docs Build status updates of commit 3e94b6a:

✅ Validation status: passed

File Status Preview URL Details
reference/7.3/Microsoft.PowerShell.Core/About/about_Functions_Advanced_Methods.md ✅Succeeded View (powershell-7.3)
reference/docs-conceptual/learn/experimental-features.md ✅Succeeded View (>=powershell-5.1)
reference/docs-conceptual/whats-new/What-s-New-in-PowerShell-73.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@sdwheeler sdwheeler merged commit 39daeb0 into MicrosoftDocs:staging Dec 17, 2021
@sdwheeler sdwheeler deleted the sdw-i8090 branch December 20, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants