Ssh rsa deprecation docs adjustments #14011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: removed not related deletion of dot at end of a sentance
|
@anurgatin : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
#label:"aq-pr-triaged" |
|
I'll check this tomorrow.
Bohdan
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Jak Koke ***@***.***>
Sent: Thursday, February 15, 2024 11:45:22 PM
To: MicrosoftDocs/azure-devops-docs ***@***.***>
Cc: Bohdan Janoušek ***@***.***>; Review requested ***@***.***>
Subject: Re: [MicrosoftDocs/azure-devops-docs] Ssh rsa deprecation docs adjustments (PR #14011)
@vijayma<https://github.com/vijayma>
* Can you review this PR?
* IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team<https://github.com/orgs/MicrosoftDocs/teams/public-repo-pr-review-team>
—
Reply to this email directly, view it on GitHub<#14011 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AYQOX74U2FCUU4XSZU27AA3YT2FYFAVCNFSM6AAAAABDKXEMHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBXGQ3DANBVGA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Updated the details related to deprecation of the SSH-RSA
bjanousek
approved these changes
Feb 16, 2024
|
#sign-off |
|
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @vijayma |
|
@Jak-MS - can you merge this PR. It's ready to go |
|
#sign-off |
|
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @vijayma |
Court72
reviewed
Feb 16, 2024
Court72
reviewed
Feb 16, 2024
Court72
reviewed
Feb 16, 2024
Court72
reviewed
Feb 16, 2024
| Host ssh.dev.azure.com vs-ssh.visualstudio.com | ||
| KexAlgorithms +diffie-hellman-group-exchange-sha256,+diffie-hellman-group14-sha1,+diffie-hellman-group1-sha1 | ||
| ``` | ||
| You may have previously modified your SSH config to downgrade your security settings for Azure DevOps by adding the following to your `~/.ssh/config` (`%UserProfile%\.ssh\config` on Windows) file: |
There was a problem hiding this comment.
Suggested change
| You may have previously modified your SSH config to downgrade your security settings for Azure DevOps by adding the following to your `~/.ssh/config` (`%UserProfile%\.ssh\config` on Windows) file: | |
| You may have previously modified your SSH config to downgrade your security settings for Azure DevOps by adding the following to your `~/.ssh/config` (`%UserProfile%\.ssh\config` on Windows) file: |
Court72
reviewed
Feb 16, 2024
|
Hello Courtney,
as per the message in Teams to your MS account:
When merging the changes for this PR there are issue with some texts that does not render correctly. When I've checked the preview in "main" branch I see the "important" texts are not rendered OK after you've changed the numbers to bullet points. Can you fix that?
Specifically these are the two
[cid:a5d0654e-aa33-4c73-9a2b-731d1a619ce1]
Thanks,
Bohdan Janousek
Senior Program Manager
Azure DevOps
***@***.***
[Microsoft Logo]
…________________________________
From: Courtney Wales ***@***.***>
Sent: Friday, February 16, 2024 4:35 PM
To: MicrosoftDocs/azure-devops-docs ***@***.***>
Cc: Bohdan Janoušek ***@***.***>; Assign ***@***.***>
Subject: Re: [MicrosoftDocs/azure-devops-docs] Ssh rsa deprecation docs adjustments (PR #14011)
Merged #14011<#14011> into main.
—
Reply to this email directly, view it on GitHub<#14011 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AYQOX7553IHXMIDMWO3GUDTYT54CZAVCNFSM6AAAAABDKXEMHCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHAZTANBQGE2TSNA>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have announced
SSH-RSAcipher deprecation. This PR suppose to adjust public docs we provide about setting ssh key for ado git experience according to incomming changessee: https://devblogs.microsoft.com/devops/ssh-rsa-deprecation/