Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes 2.0.29 #683

Merged
merged 2 commits into from Mar 15, 2018
Merged

Release notes 2.0.29 #683

merged 2 commits into from Mar 15, 2018

Conversation

derekbekoe
Copy link
Contributor

cc: @sptramer

@formulahendry
Copy link
Contributor

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/release-notes-azure-cli.md ✅Succeeded View (azure-cli-latest)
View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@formulahendry
Copy link
Contributor

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/release-notes-azure-cli.md ✅Succeeded View (azure-cli-latest)
View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Copy link
Contributor

@sptramer sptramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes before final edit.

### Appservice

* Deprecated `[webapp|functionapp] assign-identity`
* webapp/functionapp: author managed identity commands `identity assign/show` [?]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this means.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 'author' should really be just 'add' which would make it clearer.

### Interactive

* Persist history across different sessions
* Fixed history while in scope [#]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires link to issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williexu Can you provide the issue link?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Persistence: Azure/azure-cli#5625
History with scope: Azure/azure-cli#3016


* Persist history across different sessions
* Fixed history while in scope [#]
* Fixed progress meter for long running operations [#]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires link to issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williexu Can you provide the issue link?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no issue for this, I just made a pr that included this change. In interactive, you can use --progress to start a thread with the operation, and a progress meter will appear. This was broken.

* Persist history across different sessions
* Fixed history while in scope [#]
* Fixed progress meter for long running operations [#]
* Completions more robust to command table exceptions [?]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this means

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@williexu williexu Mar 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When interactive mode starts up, a command table is loaded and there may be errors (especially when using the stack profile) such as missing parameters.
This causes the table loading and the completers (which rely on the table) to fail.
The change catches these exceptions, and enables the command table to continue loading.
Azure/azure-cli#5688

* `network express-route update`
* `network nsg rule update`
* `network public-ip update`
* `traffic manager profile update` [?]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what command this actually is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

traffic-manager profile update

### Network

* [BREAKING CHANGE] Removed `--tags` parameter from `route-filter rule create`
* Removed some erroneous default values for the following commands:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was originally a "fixed" indicating it has an associated issue. Requires link(s)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there was a specific issue posted for this.

### Storage

* Fixed issue with missing endpoint suffix in `storage blob copy` [#] [?]
* Fixed issue where `storage blob [delete-batch|download-batch|upload-batch]` commands would throw an error [#]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires issue link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


### Storage

* Fixed issue with missing endpoint suffix in `storage blob copy` [#] [?]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires issue link, and not sure what command it refers to. Could not find a blob copy command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekbekoe
Copy link
Contributor Author

@sptramer We haven't been requiring links to issues in all other releases. Often times, the changes don't have an associated GitHub issue or it's difficult to parse through the commits to find the GitHub issue. Why are we starting to do it now?

@sptramer
Copy link
Contributor

If there is an associated github issue, it should be linked in the changelog. This is standard practice for open source products which fix issues reported through github.

@derekbekoe
Copy link
Contributor Author

@sptramer All questions answered. Can you take another look?

@formulahendry
Copy link
Contributor

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/release-notes-azure-cli.md ✅Succeeded View (azure-cli-latest)
View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@formulahendry
Copy link
Contributor

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/release-notes-azure-cli.md ✅Succeeded View (azure-cli-latest)
View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@sptramer sptramer merged commit 3a2fc63 into MicrosoftDocs:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants