-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Known Limitations for Azure Files Share #106637
Update Known Limitations for Azure Files Share #106637
Conversation
The original text was not clear, so I have clarified the following. Virtual nodes currently don't support Persistent Volumes and Persistent Volume Claims. In addition, the document linked to as an example in "Follow the instructions for mounting a volume with Azure Files share." is incorrect, so the link changed to an example of an inline volume.
@tbuchi888 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 5f5f6d0: ✅ Validation status: passed
For more details, please refer to the build report. Note: Links can become broken if there are changes on the target sites. For any questions, please:
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tbuchi888 - Thanks for submitting this PR to improve information being described about Az Files Shares support. I suggested a minor change to be made before I can approve this for merge. Thanks!
articles/aks/virtual-nodes.md
Outdated
@@ -40,7 +40,7 @@ Virtual nodes functionality is heavily dependent on ACI's feature set. In additi | |||
* Virtual nodes support scheduling Linux pods. You can manually install the open source [Virtual Kubelet ACI](https://github.com/virtual-kubelet/azure-aci) provider to schedule Windows Server containers to ACI. | |||
* Virtual nodes require AKS clusters with Azure CNI networking. | |||
* Using api server authorized ip ranges for AKS. | |||
* Volume mounting Azure Files share support [General-purpose V2](../storage/common/storage-account-overview.md#types-of-storage-accounts) and [General-purpose V1](../storage/common/storage-account-overview.md#types-of-storage-accounts). Follow the instructions for mounting [a volume with Azure Files share](azure-files-csi.md). | |||
* Volume mounting Azure Files share support [General-purpose V2](../storage/common/storage-account-overview.md#types-of-storage-accounts) and [General-purpose V1](../storage/common/storage-account-overview.md#types-of-storage-accounts). But virtual nodes currently don't support [Persistent Volumes](concepts-storage.md#persistent-volumes) and [Persistent Volume Claims](concepts-storage.md#persistent-volume-claims). Follow the instructions for mounting [a volume with Azure Files share as an inline volume](azure-csi-files-storage-provision.md#mount-file-share-as-an-inline-volume). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the only minor change I'm suggesting to make is to this sentence -
However, virtual nodes currently don't support Persistent Volumes and Persistent Volume Claims.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MGoedtel - I appreciate your suggestion. I have made a minor change to that one sentence. Thanks.
As suggested, minor change of only one sentence.
Learn Build status updates of commit 65b6cbd: ✅ Validation status: passed
For more details, please refer to the build report. Note: Links can become broken if there are changes on the target sites. For any questions, please:
|
@MGoedtel - I have made a minor correction to that sentence to your suggestion. Please review it. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the requested change. I approve for merge.
#sign-off |
The original text was not clear, so I have clarified the following. Virtual nodes currently don't support Persistent Volumes and Persistent Volume Claims. In addition, the document linked to as an example in "Follow the instructions for mounting a volume with Azure Files share." is incorrect, so the link changed to an example of an inline volume.
@MGoedtel,
This is a reopening of the #84855 / PR#84891 with an update of the linked document to the CSI storage driver.
Thanks.