Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Known Limitations for Azure Files Share #106637

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

tbuchi888
Copy link
Contributor

@tbuchi888 tbuchi888 commented Mar 15, 2023

The original text was not clear, so I have clarified the following. Virtual nodes currently don't support Persistent Volumes and Persistent Volume Claims. In addition, the document linked to as an example in "Follow the instructions for mounting a volume with Azure Files share." is incorrect, so the link changed to an example of an inline volume.

@MGoedtel,
This is a reopening of the #84855 / PR#84891 with an update of the linked document to the CSI storage driver.
Thanks.

The original text was not clear, so I have clarified the following.
Virtual nodes currently don't support Persistent Volumes and Persistent Volume Claims.
In addition, the document linked to as an example in "Follow the instructions for mounting a volume with Azure Files share." is incorrect, so the link changed to an example of an inline volume.
@prmerger-automator
Copy link
Contributor

@tbuchi888 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 5f5f6d0:

✅ Validation status: passed

File Status Preview URL Details
articles/aks/virtual-nodes.md ✅Succeeded

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Mar 15, 2023

@MGoedtel

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Mar 15, 2023
Copy link
Contributor

@MGoedtel MGoedtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbuchi888 - Thanks for submitting this PR to improve information being described about Az Files Shares support. I suggested a minor change to be made before I can approve this for merge. Thanks!

@@ -40,7 +40,7 @@ Virtual nodes functionality is heavily dependent on ACI's feature set. In additi
* Virtual nodes support scheduling Linux pods. You can manually install the open source [Virtual Kubelet ACI](https://github.com/virtual-kubelet/azure-aci) provider to schedule Windows Server containers to ACI.
* Virtual nodes require AKS clusters with Azure CNI networking.
* Using api server authorized ip ranges for AKS.
* Volume mounting Azure Files share support [General-purpose V2](../storage/common/storage-account-overview.md#types-of-storage-accounts) and [General-purpose V1](../storage/common/storage-account-overview.md#types-of-storage-accounts). Follow the instructions for mounting [a volume with Azure Files share](azure-files-csi.md).
* Volume mounting Azure Files share support [General-purpose V2](../storage/common/storage-account-overview.md#types-of-storage-accounts) and [General-purpose V1](../storage/common/storage-account-overview.md#types-of-storage-accounts). But virtual nodes currently don't support [Persistent Volumes](concepts-storage.md#persistent-volumes) and [Persistent Volume Claims](concepts-storage.md#persistent-volume-claims). Follow the instructions for mounting [a volume with Azure Files share as an inline volume](azure-csi-files-storage-provision.md#mount-file-share-as-an-inline-volume).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the only minor change I'm suggesting to make is to this sentence -
However, virtual nodes currently don't support Persistent Volumes and Persistent Volume Claims.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MGoedtel - I appreciate your suggestion. I have made a minor change to that one sentence. Thanks.

As suggested, minor change of only one sentence.
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 65b6cbd:

✅ Validation status: passed

File Status Preview URL Details
articles/aks/virtual-nodes.md ✅Succeeded

For more details, please refer to the build report.

Note: Links can become broken if there are changes on the target sites.

For any questions, please:

@tbuchi888
Copy link
Contributor Author

@MGoedtel - I have made a minor correction to that sentence to your suggestion. Please review it. Thanks.

Copy link
Contributor

@MGoedtel MGoedtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the requested change. I approve for merge.

@MGoedtel
Copy link
Contributor

#sign-off

@Court72 Court72 merged commit 26b948d into MicrosoftDocs:main Mar 21, 2023
@tbuchi888 tbuchi888 deleted the tkawabuchi-msft-patch-3 branch March 21, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants