Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove issues listed in the article for Azure CNI powered by Cilium #120815

Conversation

Copy link
Contributor

@amitmavgupta : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 5187eda:

✅ Validation status: passed

File Status Preview URL Details
articles/aks/azure-cni-powered-by-cilium.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@asudbring asudbring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitmavgupta
Can you delete the limitations instead of putting the comment that it’s fixed?
Thanks!

@ShannonLeavitt
Copy link
Contributor

ShannonLeavitt commented Mar 15, 2024

@asudbring - If it helps, the PR Review team can delete lines 54-58 and then merge the PR if you approve and sign off.

#label:"aq-pr-triaged"

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Mar 15, 2024
@asudbring
Copy link
Contributor

@ShannonLeavitt
That would be awesome! I'm good with that.

delete
#sign-off

Copy link
Contributor

@amitmavgupta : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@amitmavgupta amitmavgupta force-pushed the pr/amitmavgupta/fixciliumissues branch from e313a7e to 8fbcd14 Compare March 15, 2024 16:37
@amitmavgupta
Copy link
Contributor Author

@asudbring @ShannonLeavitt thanks for your help. There are some discussions going on with @wedaly and @tamilmani1989 and hence we should not merge this right now and wait for there inputs and guidance.

Copy link
Contributor

Learn Build status updates of commit e313a7e:

✅ Validation status: passed

File Status Preview URL Details
articles/aks/azure-cni-powered-by-cilium.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 8fbcd14:

✅ Validation status: passed

File Status Preview URL Details
articles/aks/azure-cni-powered-by-cilium.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@asudbring
Copy link
Contributor

#hold-off

Copy link
Contributor

You typed hold-off, but the PR wasn't signed off, so nothing was changed.

@asudbring
Copy link
Contributor

@amitmavgupta
Is this one ok to merge or are we still holding off?

@amitmavgupta
Copy link
Contributor Author

@asudbring we still need to hold off for some more time.

@American-Dipper
Copy link
Contributor

@asudbring - still on hold? --PR review team

@amitmavgupta
Copy link
Contributor Author

@tamilmani1989 @wedaly do we still need to hold?

@American-Dipper
Copy link
Contributor

American-Dipper commented May 22, 2024

PR review team emailed author (and his backups)

@asudbring
Copy link
Contributor

#please-close

@amitmavgupta amitmavgupta deleted the pr/amitmavgupta/fixciliumissues branch May 23, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants