-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove issues listed in the article for Azure CNI powered by Cilium #120815
Remove issues listed in the article for Azure CNI powered by Cilium #120815
Conversation
@amitmavgupta : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 5187eda: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amitmavgupta
Can you delete the limitations instead of putting the comment that it’s fixed?
Thanks!
@asudbring - If it helps, the PR Review team can delete lines 54-58 and then merge the PR if you approve and sign off. #label:"aq-pr-triaged" |
@ShannonLeavitt delete |
@amitmavgupta : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
e313a7e
to
8fbcd14
Compare
@asudbring @ShannonLeavitt thanks for your help. There are some discussions going on with @wedaly and @tamilmani1989 and hence we should not merge this right now and wait for there inputs and guidance. |
Learn Build status updates of commit e313a7e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 8fbcd14: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
#hold-off |
You typed hold-off, but the PR wasn't signed off, so nothing was changed. |
@amitmavgupta |
@asudbring we still need to hold off for some more time. |
@asudbring - still on hold? --PR review team |
@tamilmani1989 @wedaly do we still need to hold? |
PR review team emailed author (and his backups) |
#please-close |
The following issues listed in the limtations section for Azure CNI powered by Cilium are fixed. Could this be removed from the limitations section?
cc @tamilmani1989 @wedaly