Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update suse-create-upload-vhd.md #121832

Merged
merged 6 commits into from
May 7, 2024
Merged

Update suse-create-upload-vhd.md #121832

merged 6 commits into from
May 7, 2024

Conversation

mries
Copy link
Contributor

@mries mries commented Apr 21, 2024

removed end-of- life version and made adjustments to the instruction examples.

removed end-of- life version and made adjustments to the instruction examples.
Copy link
Contributor

@mries : Thanks for your contribution! The author(s) have been notified to review your proposed change.

mries added a commit to mries/azure-docs that referenced this pull request Apr 21, 2024
updating link due to changes in  document in this pull request:
MicrosoftDocs#121832
Copy link
Contributor

Learn Build status updates of commit 0d7c115:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/virtual-machines/linux/disk-encryption-sample-scripts.md ⚠️Warning Details
articles/virtual-machines/linux/suse-create-upload-vhd.md ⚠️Warning Details

articles/virtual-machines/linux/disk-encryption-sample-scripts.md

  • Line 282, Column 75: [Warning: bookmark-not-found] Cannot find bookmark '#prepare-opensuse-152' in 'articles/virtual-machines/linux/suse-create-upload-vhd.md', did you mean '#prepare-opensuse-154'?

articles/virtual-machines/linux/suse-create-upload-vhd.md

  • Line 240, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
  • Line 248, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Apr 22, 2024

@srijang

Can you review the proposed changes? Note that the validation warnings must be resolved before merging.

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@Court72 Court72 added the aq-pr-triaged tracking label for the PR review team label Apr 22, 2024
updated version number link
Copy link
Contributor

Learn Build status updates of commit d1fc86d:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/virtual-machines/linux/suse-create-upload-vhd.md ⚠️Warning Details
articles/virtual-machines/linux/disk-encryption-sample-scripts.md ✅Succeeded

articles/virtual-machines/linux/suse-create-upload-vhd.md

  • Line 240, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
  • Line 248, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 4ed83f5:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/virtual-machines/linux/suse-create-upload-vhd.md ⚠️Warning Details
articles/virtual-machines/linux/disk-encryption-sample-scripts.md ✅Succeeded

articles/virtual-machines/linux/suse-create-upload-vhd.md

  • Line 240, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).
  • Line 248, Column 1: [Warning: code-block-indented - See documentation] Indented code blocks aren't allowed. Use a Markdown code block surrounded by triple backticks (```).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 63d0b22:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/linux/disk-encryption-sample-scripts.md ✅Succeeded
articles/virtual-machines/linux/suse-create-upload-vhd.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented May 6, 2024

email sent to nudge @srijang ... cc: @amjads1

please review

sudo zypper ar -f https://download.opensuse.org/distribution/15.2/repo/oss openSUSE_15.2_OSS
sudo zypper ar -f http://download.opensuse.org/update/15.2 openSUSE_15.2_Updates
```
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the repository path need to change here?

Copy link
Contributor Author

@mries mries May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this was an oversight. I had the new repo links tested but didn't add them to the document (or, it looks like a copy paste issue) . That was an oversight. They should look like this:

sudo zypper ar -f https://download.opensuse.org/update/openSUSE-stable openSUSE_15.4_Updates
sudo zypper ar -f https://download.opensuse.org/repositories/Cloud:/Tools/15.4 Cloud:Tools_15.4
sudo zypper ar -f https://download.opensuse.org/distribution/openSUSE-stable/repo/oss openSUSE_stable_OSS

I will update in a patch.

Updated opensuse 15.4 version table and corrected links for adding repositories.
Copy link
Contributor

Learn Build status updates of commit 33d0b14:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/linux/disk-encryption-sample-scripts.md ✅Succeeded
articles/virtual-machines/linux/suse-create-upload-vhd.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 6275152:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/linux/disk-encryption-sample-scripts.md ✅Succeeded
articles/virtual-machines/linux/suse-create-upload-vhd.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS Jak-MS merged commit c43ba36 into MicrosoftDocs:main May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants