New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated sample code of Azure Key Vault. #22910
Conversation
@goh-chunlin : Thanks for your contribution! The author, @BryanLa, has been notified to review your proposed change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your change request. I agree with changing the code to use a do while instead. but for the exponentialBackoff time to account for the worst case, I would much rather have it as a long instead of an int. Can you please make that change?
This is to account for the worst case as recommended by @prashanthyv.
@goh-chunlin : Thanks for your contribution! The author, @BryanLa, has been notified to review your proposed change. |
Hi @prashanthyv, I have updated it to use long instead of int. =) However, would long make sense in real-world situations? What would be the use case that we need to such a "long" waiting time? |
Thanks @goh-chunlin ! #sign-off |
Thanks @BryanLa . @goh-chunlin - I agree that "long" would most likely not happen |
No description provided.