Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sample code of Azure Key Vault. #22910

Merged
merged 2 commits into from Jan 24, 2019
Merged

Updated sample code of Azure Key Vault. #22910

merged 2 commits into from Jan 24, 2019

Conversation

goh-chunlin
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Jan 21, 2019

CLA assistant check
All CLA requirements met.

@PRMerger19
Copy link
Contributor

@goh-chunlin : Thanks for your contribution! The author, @BryanLa, has been notified to review your proposed change.

Copy link
Contributor

@prashanthyv prashanthyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your change request. I agree with changing the code to use a do while instead. but for the exponentialBackoff time to account for the worst case, I would much rather have it as a long instead of an int. Can you please make that change?

This is to account for the worst case as recommended by @prashanthyv.
@PRMerger19
Copy link
Contributor

@goh-chunlin : Thanks for your contribution! The author, @BryanLa, has been notified to review your proposed change.

@goh-chunlin
Copy link
Contributor Author

Hi @prashanthyv, I have updated it to use long instead of int. =)

However, would long make sense in real-world situations? What would be the use case that we need to such a "long" waiting time?

@BryanLa
Copy link
Contributor

BryanLa commented Jan 24, 2019

Thanks @goh-chunlin !
I'll go ahead and get this merged, and let @prashanthyv respond in this PR when he's able.

#sign-off

@TrishaMc TrishaMc merged commit edf9865 into MicrosoftDocs:master Jan 24, 2019
@prashanthyv
Copy link
Contributor

Thanks @BryanLa . @goh-chunlin - I agree that "long" would most likely not happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants