-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Angular example for Custom Build Command #55783
Conversation
Using `ng build --prod` as a custom build command for an Angular project doesn't work since the Angular CLI isn't installed globally. This solution *does* work.
@rickvdbosch : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Hi @christiannwamba - Could you review the updates that are proposed in this pull request? Thanks. |
It's been a while. What is the current status @christiannwamba? |
@craigshoemaker @christiannwamba Could you review this pull request? Thanks! |
Pinging @craigshoemaker and @christiannwamba again 😁 |
Pinging @craigshoemaker and @christiannwamba one last time... 👋🏻 |
@georgewallace @christiannwamba - A community contribution from May needs review in the public repo. Could you take a look? Thanks. cc @tfosmark |
@rickvdbosch - so sorry for the delay! I'll test and will get you a response by the end of the week. |
No problem. It's good to know somebody is looking at it. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, @rickvdbosch!
#sign-off
@craigshoemaker, you can only sign off in the main PR conversation, not in review comments. |
#sign-off |
@craigshoemaker: I'm sorry - only the author of this article, @christiannwamba, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias. |
@christiannwamba can you please sign off on this PR? |
#sign-off |
Thanks, all. 👍 |
Using
ng build --prod
as a custom build command for an Angular project doesn't work since the Angular CLI isn't installed globally. This solution does work.