Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Angular example for Custom Build Command #55783

Merged
merged 1 commit into from
Oct 11, 2020
Merged

Fixed Angular example for Custom Build Command #55783

merged 1 commit into from
Oct 11, 2020

Conversation

rickvdbosch
Copy link
Contributor

Using ng build --prod as a custom build command for an Angular project doesn't work since the Angular CLI isn't installed globally. This solution does work.

Using `ng build --prod` as a custom build command for an Angular project doesn't work since the Angular CLI isn't installed globally. This solution *does* work.
@PRMerger10
Copy link
Contributor

@rickvdbosch : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver
Copy link
Contributor

Hi @christiannwamba - Could you review the updates that are proposed in this pull request? Thanks.

@rickvdbosch
Copy link
Contributor Author

It's been a while. What is the current status @christiannwamba?

@ktoliver ktoliver requested review from christiannwamba and removed request for christiannwamba July 6, 2020 17:10
@ktoliver
Copy link
Contributor

ktoliver commented Jul 6, 2020

@craigshoemaker @christiannwamba Could you review this pull request? Thanks!

@rickvdbosch
Copy link
Contributor Author

Pinging @craigshoemaker and @christiannwamba again 😁

@rickvdbosch
Copy link
Contributor Author

Pinging @craigshoemaker and @christiannwamba one last time...

👋🏻

@ktoliver
Copy link
Contributor

ktoliver commented Oct 6, 2020

@georgewallace @christiannwamba - A community contribution from May needs review in the public repo. Could you take a look? Thanks.

cc @tfosmark

@craigshoemaker
Copy link
Contributor

@rickvdbosch - so sorry for the delay! I'll test and will get you a response by the end of the week.

@rickvdbosch
Copy link
Contributor Author

No problem. It's good to know somebody is looking at it. 😉
To be honest I'm not sure about the ng build --prod not working anymore. It might have been fixed in the mean time 🙈

Copy link
Contributor

@craigshoemaker craigshoemaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, @rickvdbosch!

#sign-off

@PRMerger20
Copy link
Contributor

@craigshoemaker, you can only sign off in the main PR conversation, not in review comments.

@craigshoemaker
Copy link
Contributor

#sign-off

@PRMerger20
Copy link
Contributor

@craigshoemaker: I'm sorry - only the author of this article, @christiannwamba, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@craigshoemaker
Copy link
Contributor

@christiannwamba can you please sign off on this PR?

@christiannwamba
Copy link
Contributor

#sign-off

@ktoliver ktoliver merged commit 9309979 into MicrosoftDocs:master Oct 11, 2020
@ktoliver
Copy link
Contributor

Thanks, all. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants