Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update functions-timezone.md #65609

Merged
merged 1 commit into from Nov 19, 2020
Merged

Conversation

mattjohnsonpint
Copy link
Contributor

Improved several aspects of this text:

  • Removed the link given for Windows time zones because it is invalid. It is severely outdated and doesn't apply here. There is no page to link to for this. Instead, users can list the time zones on their own up-to-date system by calling tzutil /L

  • Removed the first NCRONTAB example, because it was showing a fixed UTC-5 offset without setting WEBSITE_TIME_ZONE. Since Eastern Time alternates between UTC-5 and UTC-4, and the whole point of this section is to show using the time zone setting, this just created confusion.

  • Updated other wording to be consistent with industry terminology and improve clarity.

Improved several aspects of this text:

- Removed the link given for Windows time zones because it is invalid.  It is severely outdated and doesn't apply here.  There is no page to link to for this.  Instead, users can list the time zones on their own up-to-date system by calling `tzutil /L`

- Removed the first NCRONTAB example, because it was showing a fixed UTC-5 offset without setting `WEBSITE_TIME_ZONE`.  Since Eastern Time alternates between UTC-5 and UTC-4, and the whole point of this section is to show using the time zone setting, this just created confusion.

- Updated other wording to be consistent with industry terminology and improve clarity.
@ggailey777
Copy link
Contributor

Thanks @mj1856 for your contribution. It's good to have this reviewed/fixed by a time zone nerd (which I'm not). 😉
#sign-off

@PRMerger16
Copy link
Contributor

@ggailey777: I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@ggailey777
Copy link
Contributor

#sign-off

@PRMerger8
Copy link
Contributor

@ggailey777: I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@ggailey777
Copy link
Contributor

@ktoliver or @GitHubber17 can you please merge this PR? I've added the missing metadata to this include to indicate that I'm the owner, but it still won't let me #sign-off.

@PRMerger8
Copy link
Contributor

@ggailey777: I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@ktoliver
Copy link
Contributor

ktoliver commented Nov 19, 2020

Hi @ggailey777 - I don't see a commit to add metadata in this PR. I'll merge this PR and you can check on it or update as needed in master (after the public to private sync). Thank you.

@ktoliver ktoliver merged commit 0561301 into MicrosoftDocs:master Nov 19, 2020
@ggailey777
Copy link
Contributor

@ktoliver i did that PR in private and it hadn't synced yet. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants