Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubernetes-action.md #73598

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Update kubernetes-action.md #73598

merged 1 commit into from
Apr 21, 2021

Conversation

ernani
Copy link
Contributor

@ernani ernani commented Apr 12, 2021

When running this task I got a warning annotation that made me correct this doc:

Unexpected input(s) 'force', valid inputs are ['namespace', 'container-registry-url', 'container-registry-username', 'container-registry-password', 'container-registry-email', 'secret-type', 'secret-name', 'arguments']

Force should be refactored to an argument if necessary.

When running this task I got a warning annotation that made me correct this doc:

Unexpected input(s) 'force', valid inputs are ['namespace', 'container-registry-url', 'container-registry-username', 'container-registry-password', 'container-registry-email', 'secret-type', 'secret-name', 'arguments']

Force should be refactored to an argument if necessary.
@PRMerger6
Copy link
Contributor

@ernani : Thanks for your contribution! The author(s) have been notified to review your proposed change. @azooinmyluggage

@juliakm
Copy link
Contributor

juliakm commented Apr 12, 2021

@ernani Thanks for flagging this! I've created an issue in the action repo because I am not sure if this is a code issue or a documentation problem. Please feel free to add to that issue.

Copy link

@thesattiraju thesattiraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was perhaps a documentation issue; there wasn't support for force input in the action.yml

@juliakm
Copy link
Contributor

juliakm commented Apr 21, 2021

#sign-off

@PRMerger19
Copy link
Contributor

@juliakm: I'm sorry - only the author of this article, @azooinmyluggage, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@ktoliver ktoliver merged commit 8ff2253 into MicrosoftDocs:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants