Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodInfo.Invoke #579

Closed
mairaw opened this issue Aug 3, 2018 · 12 comments
Closed

MethodInfo.Invoke #579

mairaw opened this issue Aug 3, 2018 · 12 comments
Assignees
Labels
bug Something isn't working dotnet-api/prod Pri2

Comments

@mairaw
Copy link
Collaborator

mairaw commented Aug 3, 2018

Original issue https://github.com/dotnet/docs/issues/6822 from @NetMage

MethodInfo.Invoke link under Methods in Tree goes to .Net 1.1 page instead of MethodBase.Invoke page.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@mairaw
Copy link
Collaborator Author

mairaw commented Aug 3, 2018

I could repro this. It happens when you click on the TOC link that takes you to https://docs.microsoft.com/en-us/dotnet/api/system.reflection.methodinfo.invoke?view=netframework-1.1

image

@Powerhelmsman
Copy link
Collaborator

@dend Is this your area?

@Powerhelmsman Powerhelmsman added the bug Something isn't working label Aug 3, 2018
@dend
Copy link
Contributor

dend commented Aug 7, 2018

@mairaw is the method available in the newer versions of .NET Framework?

@mairaw
Copy link
Collaborator Author

mairaw commented Aug 7, 2018

It's inherited from the parent class in newer versions @dend

@dend
Copy link
Contributor

dend commented Aug 7, 2018

I don't see its DocID in the FrameworksIndex file for 4.7.2. @mairaw - can we look at the assembly where it is, to make sure we are not missing anything in mdoc?

@dend
Copy link
Contributor

dend commented Aug 7, 2018

@mairaw actually, I see this - the bug is likely to do with the TOC versioning. Tracked here.

@dend
Copy link
Contributor

dend commented Aug 7, 2018

This is duplicate of #347 and is tracked with the bug above, so closing this item 😄

@dend dend closed this as completed Aug 7, 2018
@mairaw
Copy link
Collaborator Author

mairaw commented Aug 9, 2018

Do you also have a duplicate label @dend? Easier to see when scanning issues.

@Powerhelmsman Powerhelmsman added the duplicate This issue or pull request already exists label Aug 13, 2018
@rpetrusha
Copy link

I'm wondering if this issue should be reopened, @dend. It doesn't seem like it's a strict duplicate of #374.

The problem here is twofold:

  • The member list in the documentation for the MethodInfo type does not correctly list all members. It completely excludes the following members:
    • ContainsGenericParameters (inherited from MethodBase)
    • IsGenericMethod (inherited from MethodBase)
    • IsGenericMethodDefinition (inherited from MethodBase)
    • GetType (inherited from MethodBase)
    • Invoke(Object, Object[]) (inherited from MethodBase)
  • The MethodBase TOC includes these members. However, selecting them links to the 3.5 version of the documentation.

The reason is that, in .NET Framework 1.1 through 3.5, MethodInfo provided an implementation of these methods. However, the implementations were identical to the base class MethodBase implementations, so in .NET Framework 4, the MethodInfo implementation was removed.

@mairaw
Copy link
Collaborator Author

mairaw commented Dec 20, 2018

Can we reopen this @Powerhelmsman @dend based on @rpetrusha's feedback?

@Powerhelmsman Powerhelmsman reopened this Dec 21, 2018
@Powerhelmsman Powerhelmsman removed the duplicate This issue or pull request already exists label Dec 21, 2018
@supernova-eng supernova-eng assigned mimisasouvanh and unassigned dend Jul 31, 2019
@supernova-eng
Copy link
Contributor

Assigning to @mimisasouvanh as the PM driving the .NET experience.

@mairaw
Copy link
Collaborator Author

mairaw commented Mar 3, 2021

I don't see Invoke listed under later versions anymore, so closing this.

@mairaw mairaw closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dotnet-api/prod Pri2
Projects
None yet
Development

No branches or pull requests

7 participants