Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Guest Command Control link doesn't show any help #1550

Closed
rchiodo opened this issue Jan 22, 2019 · 9 comments
Closed

Allow Guest Command Control link doesn't show any help #1550

rchiodo opened this issue Jan 22, 2019 · 9 comments

Comments

@rchiodo
Copy link

rchiodo commented Jan 22, 2019

I enabled a code lens command in my extension and I'm trying to execute it in a live share session.

I get this error:
image

The link for more info goes here:
extensionUtil_1.ExtensionUtil.openBrowser('https://aka.ms/vsls-security#code-commands');

That anchor doesn't mention the setting to change.

@daytonellwanger
Copy link
Collaborator

@lostintangent looks like we should publish a new section on the security page.

@NatoBoram
Copy link

Is there a fix for this?

@daytonellwanger
Copy link
Collaborator

@NatoBoram , what's the issue you're running into? Missing documentation?

@NatoBoram
Copy link

When I click on "Add all missing imports", there's this message :

Code_-_Insiders_VCma5OifuE

This is despite the host explicitly allowing everything.

{
  "liveshare.allowGuestDebugControl": true,
  "liveshare.allowGuestTaskControl": true,
  "liveshare.languages.allowGuestCommandControl": true,
  "liveshare.openSharedServers": false,
  "liveshare.publishWorkspaceInfo": true,
}

When I click on "More info", I am redirected to this url : https://aka.ms/vsls-security#code-commands

But there's no #code-commands in the page.

@daytonellwanger
Copy link
Collaborator

Thanks for the info! Let me see if we can repro. @aletsdelarosa , could you see if you're able to?

@jawn
Copy link

jawn commented Aug 11, 2020

Any news? #hope

@erlangparasu
Copy link

?

@vhsw
Copy link

vhsw commented Sep 6, 2022

Any progress with this issue?

@derekbekoe derekbekoe added this to the Jan-Mar 2023 (uncommitted) milestone Nov 15, 2022
@derekbekoe derekbekoe removed the triage label Nov 15, 2022
@derekbekoe derekbekoe removed this from the Jan-Mar 2023 (uncommitted) milestone Mar 28, 2023
@derekbekoe
Copy link
Collaborator

We’re not able to prioritize this issue over the other higher-impact issues we receive every week, based on the votes and comments from others in the community and our understanding of the issue. However, rest assured that we love your input. If you feel it deserves to stay open, then clarify your use case and contact us to let us know how severe it is for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants