New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase guest limit #229

Closed
ascorbic opened this Issue Apr 22, 2018 · 12 comments

Comments

Projects
None yet
8 participants
@ascorbic

ascorbic commented Apr 22, 2018

Is the five guest limit in place for technical reasons, or is it something that can be increased? I tried using it for a class that I'm running, and was disappointed that most people couldn't join. It would be great if this could be increased. 15-person collaborative debugging would be fun, and very useful for learning.

@Chuxel

This comment has been minimized.

Collaborator

Chuxel commented Apr 22, 2018

@ascorbic Thanks for raising the issue. There is of course an upper limit where performance will degrade but that is highly dependent on the situation and we've found that the current limit provides a good experience even in resource constrained scenarios. That said, we're definitely planning to raise the limit over time at least as an option - the question is how high we should go and validate. With that in mind, a couple of questions for you:

  1. What would you see as a reasonable upper-limit?
  2. What tool was everyone using? (VS Code Mac? VS?)
@ascorbic

This comment has been minimized.

ascorbic commented Apr 23, 2018

Hi @Chuxel. In my case the limit would be around 15-20, as the course I'm running is classroom-based. We're all using VS Code Mac, and in this course currently using Chrome and Jest debugging. We'll probably use React Native too once #164 is fixed.

The upper end of those numbers (and more) would rely on something like #55 and possibly #87 if they were to be kept from getting out of hand. If those were available, this could potentially be used in much larger scenarios, such as online courses. Could read-only and pinned views help limit resource usage?

@Chuxel Chuxel removed the needs more info label Apr 23, 2018

@Chuxel

This comment has been minimized.

Collaborator

Chuxel commented Apr 23, 2018

@ascorbic Thanks. for the info! Read-only could help, but we have not gotten 20 people together to hammer on things to see where the breaking point is and we've got issues like #47 to nail down as well.

This is good info - in the past we've heard 25 being the potential upper limit, so 15-20 seems in line with that. We'll defiantly keep this in mind as we move forward!

@rgeraldporter

This comment has been minimized.

rgeraldporter commented May 9, 2018

I would also like to say more than 5 would be very useful, even if only in a read-only context. Hosting a coding workshop with remote folks in our company means using screen sharing via Slack or Skype, and the data footprint (not to mention fuzziness/clarity resulting) is much less than optimal. I would imagine the amount of data being used for a Live Share session would be much less than full on screensharing?

Also - long-term, I could see this being a great broadcast medium for coding demos across the web in general, much less data footprint of course than a twitch broadcast, though would lack the ability to play-back later.

Thank you for this feature - we've tried many solutions for addressing this and have always fallen back to awkward screensharing, I think this is the first implementation that might stick for us!

@AlanBarber

This comment has been minimized.

AlanBarber commented May 15, 2018

Just to add my two cents... I help run a developer user group and I could see using LS to do coding demos as very helpful. Allowing the attendees the ability to load up and view the codebase from their own laptop instead of just staring at the code projected up on a big screen would allow freedom to explore and look at the sample code.

That being said, in a situation like this, we would need to support upwards of 50 users at a time that would be given readonly access.

@cosmoferrito

This comment has been minimized.

cosmoferrito commented Jun 12, 2018

Can the limit be increased to more than 30. I was actually teaching a course and require a live share session so that all my 30 students can work together on a project. It would be great if LiveShare supports it

@cwadrupldijjit

This comment has been minimized.

cwadrupldijjit commented Jun 14, 2018

I also would like it to be a higher limit, as I teach a class and it would be an invaluable resource.

@Chuxel: If you're ever wanting to get a group of 20 developers going at the same time to hammer it out, I'd be willing to donate some of my time to help in that process.

@lostintangent

This comment has been minimized.

Collaborator

lostintangent commented Jun 14, 2018

@cosmoferrito @cwadrupldijjit Thanks for reaching out! Could you share a little bit about the exact use case you have in mind for Live Share? Are you thinking about using it to drive a classroom lecture, with everyone in the class interactively following along? Enabling students to collaborate with each other on group projects? Allowing students to request help from you on assignments? Something else?

We have some other planned work that might be beneficial for education scenarios, and so it would just be extremely helpful to understand the scenario you’d be interested in leveraging Live Share. Thanks!

@cwadrupldijjit

This comment has been minimized.

cwadrupldijjit commented Jun 15, 2018

@lostintangent: Any one of those scenarios could be useful. I've tried working on a project with another instructor where I was working on some back-end code and he was working on some front-end code, and that seemed to work decently (though being able to add files would be nice). Driving lectures with a read-only live share would be useful, so students can make notes based off of code they can copy and review on their own machines while preventing them from being able to directly control anything including the debugging session or terminal. Sometimes, it is useful to be able to collaborate with the student from a distance so that I could provide suggestions or solutions for them to try when they encounter problems and they reach out to me to consult with them. There's also possibility that on group projects, they could share code from one computer, though that only works as well as the person whose computer they're on is available, so unless they're mob programming, it may not be as useful.

I think you summarized many of those different applications well.

@lostintangent

This comment has been minimized.

Collaborator

lostintangent commented Jul 25, 2018

Hey everyone! In the latest Live Share update for VS Code, we enabled the ability to increase the guest limit to 30! 🚀🔥 However, this is a highly experimental feature, and so it’s not currently enabled by default. If you’d like to give it a spin, the host simply needs to set the “liveshare.features” setting to “experimental” and you’ll be good to go.

If folks try it out, please let us know how it went, and what we can do to improve. We’re currently working on read-only support as well (which we believe is a compliment to this), so we’ll keep you posted on the status of that. Thanks!

@CoolDadTx

This comment has been minimized.

CoolDadTx commented Oct 10, 2018

I need this for VS 2017. We live code in my class and I have up to 30 students writing the same code I am. Some simply cannot type fast enough so they are slowing the class down. I was hoping to use this extension to be able to code live and let students be able to copy/paste into their own VS instance if needed.

@lostintangent

This comment has been minimized.

Collaborator

lostintangent commented Oct 10, 2018

@CoolDadTx You are in luck :) This has now been addressed in the latest Live Share release, for both VS and VS Code 🔥 Note that even though this has been "promoted" to stable, you still need to enable a setting to allow up to 30 guests. Check out the release notes for more details.

I'm going to close this as resolved, but it would be awesome if folks could let us know if they start using Live Share for classrooms, and if so, how it's going 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment