Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview window in VS Code is missing images when previewing markdown #61

Closed
Chuxel opened this issue Jan 29, 2018 · 2 comments
Closed

Comments

@Chuxel
Copy link
Member

Chuxel commented Jan 29, 2018

Product and Version [VS/VSCode]: VS Code 1.20.0-insiders
OS Version [macOS/Windows]: macOS and Windows
Live Share Extension Version: 0.2.58
Target Platform or Language [e.g. Node.js]: Markdown

Steps to reproduce:

  1. Owner: Clone https://github.com/MicrosoftDocs/live-share
  2. Owner: Open README.md
  3. Owner: Share
  4. Participant: Join from VS Code - README.md should appear
  5. Participant: Click on the preview split pane icon in the upper right corner 

Expected: Markdown preview for README.md appears with images.
 
Actual: Markdown preview appears but is missing images and a message that says "Some content has been disabled in this document" This is true both for "bang syntax" images and inline HTML w/relative path src entries.

@kmasuyama
Copy link

kmasuyama commented Jul 5, 2019

I'm also looking for images to be supported over liveshare.

An image link to a local file working properly on my host vscode instance shows up as a broken link (thumbnail + alt text) on my guest instance. Using a web-hosted image link works fine.

Also, plantuml diagrams supported by the markdown-preview-enhanced extension show up as Error: write EPIPE.(edit: working now, not sure what changed)

To reproduce:

  1. install markdown-preview-enhanced
  2. preview sample markdown code

This is now working (edited)

```puml
@startuml
start
:hoge;
stop
@enduml
```

This does not work
![alt text](image_in_same_folder.jpg)

This works
![alt text](https://visualstudiomagazine.com/articles/2019/06/05/~/media/ECG/visualstudiomagazine/Images/2017/08/0817vsm_vs_code_icon.jpg)

Product and Version [VS/VSCode]: VS Code 1.36.0
OS Version [macOS/Windows]: Windows 10 1809
Live Share Extension Version: 1.0.488
Target Platform or Language [e.g. Node.js]: Markdown

@fubaduba
Copy link
Contributor

This issue has been closed due to no recent activity. We have made many updates to Live Share since this issue, and incorporated a lot of the feedback. Please re-open the issue if the problem still persists.
-Live Share team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants