Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Fix OPS build warnings #525

Merged
merged 4 commits into from
Sep 23, 2019
Merged

Fix OPS build warnings #525

merged 4 commits into from
Sep 23, 2019

Conversation

natke
Copy link
Member

@natke natke commented Sep 20, 2019

  • Remove private docset configs (these do not exist)
  • Temporarily remove attribute example in the style guide (see Add @Private attribute when 0.10 is released #524)
  • Update xrefs
  • Fix xref_query_tags in the API docset, so that UIDs in the articles docset are resolved

@acrolinxatmsft1
Copy link
Collaborator

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Acrolinx
Score
Lowest
Category
Score
Issues Scorecard Processed
articles/contributing/style-guide.md 79 59 112 link
articles/libraries/chemistry/concepts/algorithms.md 72 48 83 link
articles/libraries/chemistry/concepts/second-quantization.md 70 42 107 link
articles/libraries/standard/prelude.md 74 41 106 link

More info about Acrolinx

@opbld30
Copy link

opbld30 commented Sep 20, 2019

Docs Build status updates of commit 6484a85:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.publish.config.json ✅Succeeded
articles/contributing/style-guide.md ✅Succeeded View (qsharp-preview)
articles/libraries/chemistry/concepts/algorithms.md ✅Succeeded View (qsharp-preview)
articles/libraries/chemistry/concepts/second-quantization.md ✅Succeeded View (qsharp-preview)
articles/libraries/standard/prelude.md ✅Succeeded View (qsharp-preview)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@acrolinxatmsft1
Copy link
Collaborator

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Acrolinx
Score
Lowest
Category
Score
Issues Scorecard Processed
articles/contributing/style-guide.md 79 59 112 link
articles/libraries/chemistry/concepts/algorithms.md 72 48 83 link
articles/libraries/chemistry/concepts/second-quantization.md 70 42 107 link
articles/libraries/standard/prelude.md 74 41 106 link
articles/techniques/index.md 93 58 1 link

More info about Acrolinx

@opbld30
Copy link

opbld30 commented Sep 20, 2019

Docs Build status updates of commit fa7d530:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.publish.config.json ✅Succeeded
articles/contributing/style-guide.md ✅Succeeded View (qsharp-preview)
articles/libraries/chemistry/concepts/algorithms.md ✅Succeeded View (qsharp-preview)
articles/libraries/chemistry/concepts/second-quantization.md ✅Succeeded View (qsharp-preview)
articles/libraries/standard/prelude.md ✅Succeeded View (qsharp-preview)
articles/techniques/index.md ✅Succeeded View (qsharp-preview)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@natke natke requested a review from cgranade September 20, 2019 23:47
@natke natke changed the title WIP: Fix OPS build warnings Fix OPS build warnings Sep 20, 2019
@acrolinxatmsft1
Copy link
Collaborator

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Acrolinx
Score
Lowest
Category
Score
Issues Scorecard Processed
articles/contributing/style-guide.md 79 59 110 link
articles/libraries/chemistry/concepts/algorithms.md 72 48 83 link
articles/libraries/chemistry/concepts/second-quantization.md 70 42 107 link
articles/libraries/standard/prelude.md 75 45 99 link
articles/techniques/index.md 93 58 1 link

More info about Acrolinx

@opbld31
Copy link

opbld31 commented Sep 23, 2019

Docs Build status updates of commit 4cc182c:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.publish.config.json ✅Succeeded
articles/contributing/style-guide.md ✅Succeeded View (qsharp-preview)
articles/libraries/chemistry/concepts/algorithms.md ✅Succeeded View (qsharp-preview)
articles/libraries/chemistry/concepts/second-quantization.md ✅Succeeded View (qsharp-preview)
articles/libraries/standard/prelude.md ✅Succeeded View (qsharp-preview)
articles/techniques/index.md ✅Succeeded View (qsharp-preview)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Copy link
Contributor

@cgranade cgranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I just had the one question, namely if it would make sense to keep the advice and guidance about using initial underscores _ to indicate private names until @Private() is included in a released version of the Microsoft.Quantum.Core namespace.

@opbld32
Copy link

opbld32 commented Sep 23, 2019

Docs Build status updates of commit d36c89d:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.publish.config.json ✅Succeeded
articles/contributing/style-guide.md ✅Succeeded View (qsharp-preview)
articles/libraries/chemistry/concepts/algorithms.md ✅Succeeded View (qsharp-preview)
articles/libraries/chemistry/concepts/second-quantization.md ✅Succeeded View (qsharp-preview)
articles/libraries/standard/prelude.md ✅Succeeded View (qsharp-preview)
articles/techniques/index.md ✅Succeeded View (qsharp-preview)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@acrolinxatmsft1
Copy link
Collaborator

Acrolinx Scorecards

A minimum Acrolinx score of 80 is required.

Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article Acrolinx
Score
Lowest
Category
Score
Issues Scorecard Processed
articles/contributing/style-guide.md 79 58 114 link
articles/libraries/chemistry/concepts/algorithms.md 72 48 83 link
articles/libraries/chemistry/concepts/second-quantization.md 70 42 107 link
articles/libraries/standard/prelude.md 75 45 99 link
articles/techniques/index.md 93 58 1 link

More info about Acrolinx

@natke natke merged commit 9f11911 into MicrosoftDocs:master Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants