Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opacity docs #416

Merged
merged 2 commits into from Oct 8, 2021
Merged

Opacity docs #416

merged 2 commits into from Oct 8, 2021

Conversation

zadjii-msft
Copy link
Contributor

Docs microsoft/terminal#11180

Most of the diff is due to me flipping the order of these sections.

@opbld30
Copy link

opbld30 commented Sep 20, 2021

Docs Build status updates of commit 9c49494:

⚠️ Validation status: warnings

File Status Preview URL Details
TerminalDocs/tips-and-tricks.md ⚠️Warning View Details
TerminalDocs/customize-settings/profile-appearance.md ✅Succeeded View

TerminalDocs/tips-and-tricks.md

  • Line 41, Column 263: [Warning-bookmark-not-found] Cannot find bookmark '#acrylic' in 'customize-settings/profile-appearance.md'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld32
Copy link

opbld32 commented Sep 20, 2021

Docs Build status updates of commit 91c2d72:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/profile-appearance.md ✅Succeeded View
TerminalDocs/tips-and-tricks.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

ghost pushed a commit to microsoft/terminal that referenced this pull request Sep 20, 2021
## Summary of the Pull Request
![603-final](https://user-images.githubusercontent.com/18356694/132585665-afed3210-257a-4fee-9b43-4273a0f5cf69.gif)

Adds support for vintage style opacity, on Windows 11+. The API we're using for this exists since the time immemorial, but there's a bug in XAML Islands that prevents it from working right until Windows 11 (which we're working on backporting).

Replaces the `acrylicOpacity` setting with `opacity`, which is a uint between 0 and 100 (inclusive), default to 100.

`useAcrylic` now controls whether acrylic is used or not. Setting an opacity < 100 with `"useAcrylic": false` will use vintage style opacity.

Mouse wheeling adjusts opacity. Whether acrylic is used or not is dependent upon `useAcrylic`.

`opacity` will stealthily default to 50 if `useAcrylic:true` is set.

## PR Checklist
* [x] Closes #603
* [x] I work here
* [x] Tests added/passed
* [x] MicrosoftDocs/terminal#416

## Detailed Description of the Pull Request / Additional comments

Opacity was moved to AppearanceConfig. In the future, I have a mind to allow unfocused acrylic, so that'll be important then. 

## Validation Steps Performed
_just look at it_
@cinnamon-msft cinnamon-msft changed the base branch from master to release-1.12 October 8, 2021 21:11
@cinnamon-msft cinnamon-msft merged commit 794eee6 into release-1.12 Oct 8, 2021
@cinnamon-msft cinnamon-msft deleted the dev/migrie/opacity branch October 8, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants