Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MD046/code-block-style #3584

Closed

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Jul 5, 2019

Code block style set to fenced caught some accidental blocks from indenting.
It also found a broken table

Code block style set to fenced caught some accidental blocks from indenting.
It also found a broken table
@nschonni nschonni force-pushed the fix--MD046/code-block-style branch from c6a9154 to 8687306 Compare July 5, 2019 06:41
@@ -52,7 +52,7 @@ The steps in this walkthrough show you how to create a new XML document. The wal

- **employee** to add the root element.

2. Select **<!--** to add a comment node and press **Enter**.
2. Select **&lt;!--** to add a comment node and press **Enter**.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is a Markdownlint bug, that causes a false positive without the change, but it renders the same. I'll file an upstream issue

@ktoliver
Copy link
Contributor

ktoliver commented Jul 5, 2019

We're in the process of pulling this commit to the private repository so we can verify the updates on staging. We'll post a new private repo PR # shortly and then close this PR.

@ktoliver ktoliver added the aq-pr-triaged tracking label for the PR review team label Jul 5, 2019
@ktoliver
Copy link
Contributor

ktoliver commented Jul 5, 2019

Private repo PR 4961 replaces this pull request. We moved the commit to the private repo so we can validate formatting changes by using automated validation and staging. We'll close this PR now.

@nschonni - Thank you!

@ktoliver ktoliver closed this Jul 5, 2019
@nschonni nschonni deleted the fix--MD046/code-block-style branch July 5, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aq-pr-triaged tracking label for the PR review team do-not-merge
Projects
None yet
3 participants