Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Powertoys docs #3436

Merged
merged 23 commits into from Nov 8, 2021
Merged

Update Powertoys docs #3436

merged 23 commits into from Nov 8, 2021

Conversation

@PRMerger10
Copy link
Contributor

@Jay-o-Way : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger15
Copy link
Contributor

@Jay-o-Way : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver
Copy link
Contributor

#label:"aq-pr-triaged"

@PRMerger9 PRMerger9 added the aq-pr-triaged tracking label for the PR review team label Oct 27, 2021
@Jay-o-Way Jay-o-Way changed the title Update docs Update Powertoys docs Oct 27, 2021
@ktoliver
Copy link
Contributor

Hi @Jay-o-Way @mattwojo - In this repository, to reference an image in an MD file, the image must be added to the repo as a file in the pull request. This is a blocking item in the internal pull request quality criteria. Thanks.

@Jay-o-Way
Copy link
Contributor Author

Jay-o-Way commented Oct 27, 2021

image must be added to the repo

Done.

Question though: for the issue about PowerToys Awake naming, the text in the menu would like to be updated too. I don't know or see how to get there. Is that something I can do or does that need special access?

@ktoliver
Copy link
Contributor

@Jay-o-Way I don't know how to request changes to the UI. @mattwojo Do you know?

@PRMerger12
Copy link
Contributor

@Jay-o-Way : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger13
Copy link
Contributor

@Jay-o-Way : Thanks for your contribution! The author(s) have been notified to review your proposed change.

2 similar comments
@PRMerger-2
Copy link
Contributor

@Jay-o-Way : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger18
Copy link
Contributor

@Jay-o-Way : Thanks for your contribution! The author(s) have been notified to review your proposed change.

- add location of zones-settings.json
- "note" to "tip" and "note" to "important"
- "etc"
@PRMerger12
Copy link
Contributor

@Jay-o-Way : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger20
Copy link
Contributor

@Jay-o-Way : Thanks for your contribution! The author(s) have been notified to review your proposed change.

image is updated in #3442
@PRMerger20
Copy link
Contributor

@Jay-o-Way : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger12
Copy link
Contributor

@Jay-o-Way : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger16
Copy link
Contributor

@Jay-o-Way : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mattwojo
Copy link
Contributor

mattwojo commented Nov 8, 2021

image must be added to the repo

Done.

Question though: for the issue about PowerToys Awake naming, the text in the menu would like to be updated too. I don't know or see how to get there. Is that something I can do or does that need special access?

Hey @Jay-o-Way -- Trying to make sure that I understand the issue here... so the intention is for the Awake feature to be officially called "PowerToys Awake" and it needs to be renamed as such in the TOC? (The left-side table of contents menu). The TOC menu file for PowerToys is located here: https://github.com/MicrosoftDocs/windows-uwp/blob/e45f5e769fad664fb3105283494e47282acf5ab5/hub/dev-environment/toc.yml
I'm happy to make that change.. just want to be sure I'm understanding correctly.

You can also choose to retain the original *last modified* date on the resized image.
<!-- [Jay] remove following warning if/when a solution is committed -->
> [!IMPORTANT]
> As mentioned above, you can use a backslash to create a new folder upon execution. Please be aware that, at this point - until a fix is committed, all special charaters are not filtered. For example: giving a preset a name with "1/4" in it, will also unintentionally create a folder. A colon `:` will result in corrupted files. For a complete list, see https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#file-and-directory-names.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make links like this one relative, so a more standard way to link this section is, that doesn't include a 'hardcoded' language-location in the URL (including the 'en-us' will force the link to show up in English, excluding it will allow the browser to choose based on the current language setting), so here's my recommended change:
For a complete list, see File and Directory Names in the WIN32 Local File Systems docs.

@PRMerger14
Copy link
Contributor

@mattwojo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

@mattwojo mattwojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREAT updates!! Thank you Jay!!!

@mattwojo mattwojo merged commit b945824 into MicrosoftDocs:docs Nov 8, 2021
@PRMerger20
Copy link
Contributor

@mattwojo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jay-o-Way
Copy link
Contributor Author

Jay-o-Way commented Nov 9, 2021

I see you solved both your comments. Thanks. That's why we have you to check 🙂 the section with the link in it will be obsolete soon, so it will probably be removed in the future anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet