Fix C# code compile erros #3940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix doesn't make this sample working. It just makes the C# code be able to be compiled. --- **Other issues** - There is no C# code in [Step 5](https://docs.microsoft.com/en-us/windows/apps/windows-app-sdk/notifications/app-notifications/app-notifications-quickstart?tabs=cs#step-5-process-a-user-selecting-a-notification). - There is no C# code in [Step 6](https://docs.microsoft.com/en-us/windows/apps/windows-app-sdk/notifications/app-notifications/app-notifications-quickstart?tabs=cs#step-6-remove-notifications). - In *Step 3* there is reference to `ToastWithTextBox.ScenarioId` which is not implemented anywhere. - Calling `AppNotificationManager.Default.Register();` throws *Error HRESULT E_FAIL has been returned from a call to a COM component* error. --- For me *Getting started* example could loook something like: ```cs public static bool SendNotificationToast(string title, string message) { var xmlPayload = new string($@" <toast> <visual> <binding template=""ToastGeneric""> <text>{title}</text> <text>{message}</text> </binding> </visual> </toast>"); var toast = new AppNotification(xmlPayload); AppNotificationManager.Default.Show(toast); return toast.Id != 0; } It's good starting point for the developer wanting to notify the user about something, where it's not important what the user will do with the notification. In such case there is no need for updating the `Package.appxmanifest` file, nor to build `NotificationManager`. Single function with few lines of code is enough for that :-) ```
|
|
|
@KubaSzostak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Can you review this PR? IMPORTANT: When this content is ready to merge, you must add #label:"aq-pr-triaged" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix doesn't make this sample working. It just makes the C# code be able to be compiled.
Other issues
ToastWithTextBox.ScenarioIdwhich is not implemented anywhere.AppNotificationManager.Default.Register();throws Error HRESULT E_FAIL has been returned from a call to a COM component error.For me Getting started example could loook something like:
It's good starting point for the developer wanting to notify the user about something (not always it's important what the user will do with the notification). In such case there is no need for updating the
Package.appxmanifestfile, nor to buildNotificationManager. Single function with few lines of code is enough for that :-)