Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPUSets for game development: Fix code snippets #4900

Open
wants to merge 1 commit into
base: docs
Choose a base branch
from

Conversation

CookiePLMonster
Copy link

This PR fixes multiple issues with code snippets on the CPUSets for game development page:

  1. An example usage of SetThreadSelectedCpuSets incorrectly referenced SYSTEM_CPU_SET_INFORMATION by index, while it is specifically forbidden by the structure docs.
  2. An example for Reducing the cost of cache coherence with last level cache also did the above mistake, but the code did not even compile to begin with. I fixed the code snippet so it compiles, does less copies, and does not misuse SYSTEM_CPU_SET_INFORMATION. This code is still sub-optimal, but now it at least works.

Fixes #3025.

Copy link
Contributor

@CookiePLMonster : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit c9881b5:

✅ Validation status: passed

File Status Preview URL Details
uwp/xbox-apps/cpusets-games.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code snippet in one of "CPUSets for game development" sections can be misleading
2 participants