Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nf-fltkernel-fltcreatefileex.md #423

Closed
wants to merge 1 commit into from

Conversation

Cloud-Writer
Copy link
Member

This is a request via Content Idea request 99478 to add this note from FltQueryInformationFile to this function as well.

This is a request via Content Idea request 99478 to add this note from FltQueryInformationFile to this function as well.
Copy link
Contributor

@rodwiddowson rodwiddowson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s better to say “do not call with a non null top level IRP”. If you are calling IoGetTopLevelIrp except in an assert you probably have an architectural issue

@Cloud-Writer
Copy link
Member Author

It’s better to say “do not call with a non null top level IRP”. If you are calling IoGetTopLevelIrp except in an assert you probably have an architectural issue

@rodwiddowson, I checked with the engineer who asked for the update, and he is fine with using the verbiage you proposed. He would like this text to be updated for the FltQueryInformationFile function as well because that is where he took the text from.

wdkbot pushed a commit that referenced this pull request Apr 26, 2019
Add to FltCreateFile, FltCreateFileEx, FltCreateFileEx2
@lorihollasch
Copy link
Member

@Cloud-Writer , I was able to get this update made in a private repo along with some other work I was doing, so am just going to close out your PR here. Thanks for flagging this, and thanks to @rodwiddowson for language finesse around top level IRQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants