-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix swapped MP2 and MP3 GUIDs #3742
Conversation
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in ksmedia.h are in reverse order. Update documentation to the correct GUIDs as defined in ksmedia.h. Based on Windows SDK 10.0.22621. Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
Learn Build status updates of commit 6d7b88c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in ksmedia.h are in reverse order. See: MicrosoftDocs/windows-driver-docs#3742
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in ksmedia.h are in reverse order. See: MicrosoftDocs/windows-driver-docs#3742
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in ksmedia.h are in reverse order. See: MicrosoftDocs/windows-driver-docs#3742
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in ksmedia.h are in reverse order. See: MicrosoftDocs/windows-driver-docs#3742
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in ksmedia.h are in reverse order. See: MicrosoftDocs/windows-driver-docs#3742
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kasper93 - Thanks for this PR. It looks like this is an error, as the current kdmedia.h header has these in the order that your fix shows, MPEG2 and then MPEG3.
Thanks for helping make the audio docs better!
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in ksmedia.h are in reverse order. See: MicrosoftDocs/windows-driver-docs#3742
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in ksmedia.h are in reverse order.
Update documentation to the correct GUIDs as defined in ksmedia.h.
Based on Windows SDK 10.0.22621.