Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swapped MP2 and MP3 GUIDs #3742

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

kasper93
Copy link
Contributor

@kasper93 kasper93 commented Dec 2, 2023

While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in ksmedia.h are in reverse order.

Update documentation to the correct GUIDs as defined in ksmedia.h.

Based on Windows SDK 10.0.22621.

While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in
ksmedia.h are in reverse order.

Update documentation to the correct GUIDs as defined in ksmedia.h.

Based on Windows SDK 10.0.22621.

Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
Copy link
Contributor

Learn Build status updates of commit 6d7b88c:

✅ Validation status: passed

File Status Preview URL Details
windows-driver-docs-pr/audio/subformat-guids-for-compressed-audio-formats.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

kasper93 added a commit to kasper93/mpv that referenced this pull request Dec 2, 2023
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in
ksmedia.h are in reverse order.

See: MicrosoftDocs/windows-driver-docs#3742
dyphire pushed a commit to dyphire/mpv that referenced this pull request Dec 3, 2023
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in
ksmedia.h are in reverse order.

See: MicrosoftDocs/windows-driver-docs#3742
dyphire pushed a commit to dyphire/mpv that referenced this pull request Dec 3, 2023
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in
ksmedia.h are in reverse order.

See: MicrosoftDocs/windows-driver-docs#3742
dyphire pushed a commit to dyphire/mpv that referenced this pull request Dec 3, 2023
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in
ksmedia.h are in reverse order.

See: MicrosoftDocs/windows-driver-docs#3742
sfan5 pushed a commit to mpv-player/mpv that referenced this pull request Dec 3, 2023
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in
ksmedia.h are in reverse order.

See: MicrosoftDocs/windows-driver-docs#3742
Copy link
Contributor

@DOMARS DOMARS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasper93 - Thanks for this PR. It looks like this is an error, as the current kdmedia.h header has these in the order that your fix shows, MPEG2 and then MPEG3.
Thanks for helping make the audio docs better!

@DOMARS DOMARS merged commit 1270205 into MicrosoftDocs:staging Dec 4, 2023
2 checks passed
@kasper93 kasper93 deleted the ksmedia branch December 4, 2023 19:44
xrun1 pushed a commit to xrun1/mpv-svp-fix that referenced this pull request Mar 12, 2024
While CEA-861 defines MP2 as 0x5 and MP3 as 0x4, the GUIDs defined in
ksmedia.h are in reverse order.

See: MicrosoftDocs/windows-driver-docs#3742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants