Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppLocker cmdlets only work with GP #2122

Merged
merged 11 commits into from Sep 28, 2020
Merged

Conversation

isbrahm
Copy link
Contributor

@isbrahm isbrahm commented Sep 17, 2020

AppLocker cmdlets do not have any knowledge of the MDM stack. Customers using the AppLocker CSP have run into issues when trying to use the cmdlets, and there isn't a clear warning for them.

@opbld30
Copy link

opbld30 commented Sep 17, 2020

Docs Build status updates of commit 9370304:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/applocker/AppLocker.md ✅Succeeded
docset/windows/applocker/Get-AppLockerPolicy.md ✅Succeeded
docset/windows/applocker/Set-AppLockerPolicy.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@isbrahm
Copy link
Contributor Author

isbrahm commented Sep 21, 2020

@denisebmsft could you please merge this? Thanks!

@o0nj
Copy link
Contributor

o0nj commented Sep 23, 2020

@dariomws @get-itips @tseward

Peer review needed for this PR.

cc @JohanFreelancer9 for copy editing.

Thank you.

Copy link
Contributor

@get-itips get-itips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this, only one thing, the [!Note] tag needs to be removed as it is not supported on cmdlet's articles (get-help doesn't render it ok on consoles)

Copy link
Contributor

@dariomws dariomws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @get-itips.

@ghost
Copy link

ghost commented Sep 23, 2020

Also agreed with @get-itips

@opbld33
Copy link

opbld33 commented Sep 23, 2020

Docs Build status updates of commit 400f121:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/applocker/AppLocker.md ✅Succeeded
docset/windows/applocker/Get-AppLockerPolicy.md ✅Succeeded
docset/windows/applocker/Set-AppLockerPolicy.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Sep 23, 2020

Docs Build status updates of commit 0daf51c:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/applocker/AppLocker.md ✅Succeeded
docset/windows/applocker/Get-AppLockerPolicy.md ✅Succeeded
docset/windows/applocker/Set-AppLockerPolicy.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@JohanFreelancer9 JohanFreelancer9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy looks good.

@isbrahm
Copy link
Contributor Author

isbrahm commented Sep 25, 2020

@e0i are you able to merge these changes? I've removed the [!Note] tag. Thanks!

Copy link
Contributor

@denisebmsft denisebmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isbrahm

@opbld31
Copy link

opbld31 commented Sep 28, 2020

Docs Build status updates of commit 04ad0a8:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/applocker/AppLocker.md ✅Succeeded
docset/windows/applocker/Get-AppLockerPolicy.md ✅Succeeded
docset/windows/applocker/Set-AppLockerPolicy.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Sep 28, 2020

Docs Build status updates of commit 263e516:

✅ Validation status: passed

File Status Preview URL Details
docset/windows/applocker/AppLocker.md ✅Succeeded
docset/windows/applocker/Get-AppLockerPolicy.md ✅Succeeded
docset/windows/applocker/Set-AppLockerPolicy.md ✅Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@denisebmsft denisebmsft merged commit 3d26cae into MicrosoftDocs:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants